Skip to content

std: map ENOTSUP to ErrorKind::Unsupported #158580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
valentynkit wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

std: map ENOTSUP to ErrorKind::Unsupported #158580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion library/std/src/sys/io/error/unix.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,15 @@ pub fn decode_error_kind(errno: i32) -> io::ErrorKind {
libc::EXDEV => CrossesDevices,
libc::EINPROGRESS => InProgress,
libc::EMFILE | libc::ENFILE => TooManyOpenFiles,
libc::EOPNOTSUPP => Unsupported,
libc::EIO => InputOutputError,

libc::EACCES | libc::EPERM => PermissionDenied,

// EOPNOTSUPP and ENOTSUP can have the same value on some systems,
// but different values on others (e.g. Apple), so we can't use a
// match clause
x if x == libc::EOPNOTSUPP || x == libc::ENOTSUP => Unsupported,

@RalfJung RalfJung Aug 15, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is also ENOSYS mapping to the same thing. Seems better to group all 3 together.

View changes since the review


// These two constants can have the same value on some systems,
// but different values on others, so we can't use a match
// clause
Expand Down
Loading