Move std::io::BufRead to alloc::io - #158546
Merged
Merged
Conversation
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
@rustbot blocked |
This was referenced Jun 29, 2026
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_bufread
branch
from
July 2, 2026 02:00
cd4c8b8 to
e1864c0
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_bufread
branch
2 times, most recently
from
July 3, 2026 03:47
17bb815 to
2adb28d
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_bufread
branch
from
July 6, 2026 09:30
2adb28d to
72b16b3
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_bufread
branch
from
July 6, 2026 21:52
72b16b3 to
159a7a4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_bufread
branch
from
July 6, 2026 22:21
159a7a4 to
8b44677
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_bufread
branch
from
July 7, 2026 05:28
8b44677 to
964cd84
Compare
This comment has been minimized.
This comment has been minimized.
bushrat011899
force-pushed
the
alloc_io_bufread
branch
from
July 8, 2026 09:11
964cd84 to
82b55ba
Compare
clarfonthey
reviewed
Jul 18, 2026
Contributor
|
Seems straightforward, minus one small thing. Otherwise LGTM. |
More consistent with the default functions for `Read` Co-Authored-By: Clar Fon <15850505+clarfonthey@users.noreply.github.com>
Contributor
|
@bors r+ |
Contributor
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 19, 2026
…clarfonthey Move `std::io::BufRead` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158545 ## Description Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on rust-lang#158545. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 19, 2026
…clarfonthey Move `std::io::BufRead` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158545 ## Description Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on rust-lang#158545. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
This was referenced Jul 19, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 19, 2026
Rollup of 5 pull requests Successful merges: - #158546 (Move `std::io::BufRead` to `alloc::io`) - #159372 (Remove SIZE generic param from DisplayBuffer in core::net) - #159548 (miri subtree update) - #159508 (Some cleanup in `rustc_attr_parsing`) - #159539 ([rustc_abi] Customize `Debug` for `Primitive` and `Scalar`)
rust-timer
added a commit
that referenced
this pull request
Jul 19, 2026
Rollup merge of #158546 - bushrat011899:alloc_io_bufread, r=clarfonthey Move `std::io::BufRead` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: #154046 Split From: #156527 ~~Blocked On: #158545 ## Description Moves `std::io::BufRead` to `alloc::io`. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved into `alloc`. Blocked on #158545. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see #154046 (comment) for a review order and broader context for this PR.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Jul 20, 2026
…=clarfonthey Move `std::io::buffered` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158546 ## Description Moves `std::io::BufReader`/`BufWriter`/`LineWriter`/etc. to `alloc::io`. This is effectively a direct cut and paste. Blocked on rust-lang#158546. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 21, 2026
…=clarfonthey Move `std::io::buffered` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang#154046 Split From: rust-lang#156527 ~~Blocked On: rust-lang#158546 ## Description Moves `std::io::BufReader`/`BufWriter`/`LineWriter`/etc. to `alloc::io`. This is effectively a direct cut and paste. Blocked on rust-lang#158546. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang#154046 (comment) for a review order and broader context for this PR.
rust-timer
added a commit
that referenced
this pull request
Jul 21, 2026
Rollup merge of #158547 - bushrat011899:alloc_io_buffered, r=clarfonthey Move `std::io::buffered` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: #154046 Split From: #156527 ~~Blocked On: #158546 ## Description Moves `std::io::BufReader`/`BufWriter`/`LineWriter`/etc. to `alloc::io`. This is effectively a direct cut and paste. Blocked on #158546. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see #154046 (comment) for a review order and broader context for this PR.
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jul 22, 2026
Rollup of 5 pull requests Successful merges: - rust-lang/rust#158546 (Move `std::io::BufRead` to `alloc::io`) - rust-lang/rust#159372 (Remove SIZE generic param from DisplayBuffer in core::net) - rust-lang/rust#159548 (miri subtree update) - rust-lang/rust#159508 (Some cleanup in `rustc_attr_parsing`) - rust-lang/rust#159539 ([rustc_abi] Customize `Debug` for `Primitive` and `Scalar`)
pull Bot
pushed a commit
to xtqqczze/rust-lang-miri
that referenced
this pull request
Jul 22, 2026
Move `std::io::buffered` to `alloc::io` ACP: rust-lang/libs-team#755 Tracking issue: rust-lang/rust#154046 Split From: rust-lang/rust#156527 ~~Blocked On: rust-lang/rust#158546 ## Description Moves `std::io::BufReader`/`BufWriter`/`LineWriter`/etc. to `alloc::io`. This is effectively a direct cut and paste. Blocked on rust-lang/rust#158546. --- ## Notes * No AI tooling of any kind was used during the creation of this PR. * Please see rust-lang/rust#154046 (comment) for a review order and broader context for this PR.
2 tasks
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 10, 2026
…nia-e Fix swapped documentation lines on `io::Read` While reading the documentation for the `std::io::Read` trait, I noticed some wording out of order: > Please note that each call to [read()](https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read) may involve a system call, and BufReader, will be more efficient. therefore, using something that implements [BufRead](https://doc.rust-lang.org/nightly/std/io/trait.BufRead.html), such as It looks like rust-lang#158546 accidentally swapped two lines when inserting an intra-doc link; this PR swaps them back.
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Aug 10, 2026
…nia-e Fix swapped documentation lines on `io::Read` While reading the documentation for the `std::io::Read` trait, I noticed some wording out of order: > Please note that each call to [read()](https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read) may involve a system call, and BufReader, will be more efficient. therefore, using something that implements [BufRead](https://doc.rust-lang.org/nightly/std/io/trait.BufRead.html), such as It looks like rust-lang#158546 accidentally swapped two lines when inserting an intra-doc link; this PR swaps them back.
rust-timer
added a commit
that referenced
this pull request
Aug 10, 2026
Rollup merge of #160836 - Jontos:fix-read-doc-line-order, r=nia-e Fix swapped documentation lines on `io::Read` While reading the documentation for the `std::io::Read` trait, I noticed some wording out of order: > Please note that each call to [read()](https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read) may involve a system call, and BufReader, will be more efficient. therefore, using something that implements [BufRead](https://doc.rust-lang.org/nightly/std/io/trait.BufRead.html), such as It looks like #158546 accidentally swapped two lines when inserting an intra-doc link; this PR swaps them back.
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Aug 11, 2026
Fix swapped documentation lines on `io::Read` While reading the documentation for the `std::io::Read` trait, I noticed some wording out of order: > Please note that each call to [read()](https://doc.rust-lang.org/nightly/std/io/trait.Read.html#method.read) may involve a system call, and BufReader, will be more efficient. therefore, using something that implements [BufRead](https://doc.rust-lang.org/nightly/std/io/trait.BufRead.html), such as It looks like rust-lang/rust#158546 accidentally swapped two lines when inserting an intra-doc link; this PR swaps them back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
ACP: rust-lang/libs-team#755
Tracking issue: #154046
Split From: #156527
Blocked On: #158545Description
Moves
std::io::BufReadtoalloc::io. This is effectively a direct cut and paste, but with a large diff due to how many implementations need to be moved intoalloc. Blocked on #158545.Notes
alloc::ioandcore::io#154046 (comment) for a review order and broader context for this PR.