Skip to content

Pull implied bound computation out of borrowck - #152051

Closed
tiif wants to merge 1 commit into
rust-lang:mainfrom
tiif:implied-bound-opaque
Closed

Pull implied bound computation out of borrowck#152051
tiif wants to merge 1 commit into
rust-lang:mainfrom
tiif:implied-bound-opaque

Conversation

@tiif

@tiif tiif commented Feb 3, 2026

Copy link
Copy Markdown
Member

Open this draft PR so it's easier to discuss, feel free to point out any logic / soundness / error handling issues :>

Current status:

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 3, 2026
@rust-log-analyzer

This comment has been minimized.

@tiif tiif Feb 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change in this file is mainly duplicating the existing function to not use nll var. The new implied bound query needs these functions, but it doesn't makes sense to use nll var there. boxy gave some ideas on how to deduplicate this, but I haven't got to it yet.

@rust-bors

This comment has been minimized.

@lcnr
lcnr force-pushed the implied-bound-opaque branch from 91bf826 to 5e8e935 Compare August 3, 2026 13:04
@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job tidy failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
fmt: checked 7075 files
tidy check
tidy [rustdoc_json (src)]: `rustdoc-json-types` modified, checking format version
tidy: Skipping binary file check, read-only filesystem
tidy [style (compiler)]: /checkout/compiler/rustc_trait_selection/src/traits/query/type_op/implied_outlives_bounds.rs:174: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
tidy [style (tests)]: /checkout/tests/ui/borrowck/test-rename-later.rs: missing trailing newline
tidy [style (tests)]: /checkout/tests/ui/borrowck/manual_test.rs:1: line longer than 100 chars
tidy [style (tests)]: /checkout/tests/ui/borrowck/manual_test.rs: missing trailing newline
tidy [style (tests)]: /checkout/tests/ui/borrowck/manual_test0.rs:1: line longer than 100 chars
tidy [style (tests)]: /checkout/tests/ui/borrowck/manual_test0.rs: missing trailing newline
tidy [style (compiler)]: /checkout/compiler/rustc_borrowck/src/compute_rename_later.rs:1: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
tidy [style (compiler)]: /checkout/compiler/rustc_borrowck/src/lib.rs:356: TODO is used for tasks that should be done before merging a PR; If you want to leave a message in the codebase use FIXME
tidy [style (compiler)]: /checkout/compiler/rustc_borrowck/src/type_check/free_region_relations.rs:287: the `todo!` macro is used for tasks that should be done before merging a PR. If you want to panic here, use `panic!`, `unimplemented!`, `unreachable!`, `rustc_middle::bug!` or an assertion
tidy [style (compiler)]: FAIL
tidy [style (tests)]: FAIL
removing old virtual environment
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'venv'
creating virtual environment at '/checkout/obj/build/venv' using 'python3.10' and 'virtualenv'
Requirement already satisfied: pip in ./build/venv/lib/python3.10/site-packages (26.1.2)
Collecting pip
---
typechecking javascript files
tidy: The following checks failed: style (compiler), style (tests)
Bootstrap failed while executing `test src/tools/tidy tidyselftest --extra-checks=py,cpp,js,spellcheck`
Currently active steps:
test::Tidy {  } at src/bootstrap/src/core/build_steps/test.rs:1606
Command `/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-tools-bin/rust-tidy --root-path=/checkout --cargo-path=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo --output-dir=/checkout/obj/build --concurrency=4 --npm-path=/node/bin/yarn --ci=true --extra-checks=py,cpp,js,spellcheck` failed with exit code 1
Created at: src/bootstrap/src/core/build_steps/tool.rs:1627:23
Executed at: src/bootstrap/src/core/build_steps/test.rs:1684:29

Command has failed. Rerun with -v to see more details.
Build completed unsuccessfully in 0:02:33
  local time: Mon Aug  3 13:10:44 UTC 2026
  network time: Mon, 03 Aug 2026 13:10:44 GMT
##[error]Process completed with exit code 1.
##[group]Run echo "disk usage:"

@lcnr

lcnr commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

closing in favor of #160491

@lcnr lcnr closed this Aug 4, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants