Move some std tests to integration tests - #135621
Merged
Merged
Conversation
Collaborator
|
r? @Noratrieb rustbot has assigned @Noratrieb. Use |
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Member
|
cool. @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
Member
Author
|
Not yet. There are a whole bunch more tests that need to be handled. These are just some of the easier ones that are just testing the public api. There are also a lot of tests of private api's for which I don't have a good solution yet. Once all those tests are moved however we can indeed remove all |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 17, 2025
…oratrieb Move some std tests to integration tests Unit tests directly inside of standard library crates require a very fragile way of building that is hard to reproduce outside of bootstrap. Follow up to rust-lang#133859
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 17, 2025
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#134455 (cleanup promoteds move check) - rust-lang#135421 (Make tidy warn on unrecognized directives) - rust-lang#135611 (Remove unnecessary assertion for reference error) - rust-lang#135620 (ci: improve github action name) - rust-lang#135621 (Move some std tests to integration tests) - rust-lang#135639 (new solver: prefer trivial builtin impls) - rust-lang#135654 (add src/librustdoc and src/rustdoc-json-types to RUSTC_IF_UNCHANGED_ALLOWED_PATHS) r? `@ghost` `@rustbot` modify labels: rollup
Contributor
|
@bors r- I believe this failed in #135655 |
bors
added
S-waiting-on-author
Contributor
|
Thanks for the PR @bjorn3 ! We ran this PR on our internal CI for the SGX target and it fails with: I believe this is caused by the following line in the and that it should be changed to: could you please make this change? Thank you! |
Contributor
|
Just wanted to note, if it wasn't obvious why the error above happened, is that there are a bunch of One suggestion is to move the set_var ones to a separate integration test so they don't interfere. |
Member
Author
|
SGX should be fixed now. And I moved the set_var tests to a separate integration test. |
This comment has been minimized.
This comment has been minimized.
Contributor
Awesome! :) |
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Collaborator
|
☔ The latest upstream changes (presumably #136085) made this pull request unmergeable. Please resolve the merge conflicts. |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Feb 2, 2025
…oratrieb Move some std tests to integration tests Unit tests directly inside of standard library crates require a very fragile way of building that is hard to reproduce outside of bootstrap. Follow up to rust-lang#133859
matthiaskrgr
reviewed
Feb 2, 2025
Member
|
@bors r- |
bors
added
S-waiting-on-author
bjorn3
force-pushed
the
move_tests_to_stdtests
branch
from
February 2, 2025 18:28
a56ecda to
cc7e3a6
Compare
Member
Author
|
@bors r=Noratrieb |
Collaborator
bors
added
S-waiting-on-bors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests directly inside of standard library crates require a very fragile way of building that is hard to reproduce outside of bootstrap.
Follow up to #133859