Skip to content

Add APIs for dealing with titlecase - #122668

Merged
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Jules-Bertholet:titlecase
Mar 24, 2026
Merged

Add APIs for dealing with titlecase#122668
rust-bors[bot] merged 3 commits into
rust-lang:mainfrom
Jules-Bertholet:titlecase

Conversation

@Jules-Bertholet

@Jules-Bertholet Jules-Bertholet commented Mar 17, 2024 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

View all comments

ACP: rust-lang/libs-team#354
Tracking issue: #153892

r? libs-api

@rustbot label T-libs -T-libs-api A-unicode

The last commit has some insta-stable PartialEq impls, therefore: @rustbot label -needs-fcp
Alternatively, I could split those out into a follow-up PR. (Edit: will do in follow-up)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. A-Unicode Area: Unicode S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. T-libs-api [DEPRECATED; DO NOT USE] labels Mar 17, 2024
@bors

bors commented Mar 29, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #122616) made this pull request unmergeable. Please resolve the merge conflicts.

@bors

bors commented Apr 20, 2024

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #122013) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC Dylan-DPC removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 3, 2024
@rustbot

rustbot commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator

library/core/src/unicode/unicode_data.rs is generated by the src/tools/unicode-table-generator tool.

If you want to modify unicode_data.rs, please modify the tool then regenerate the library source file via ./x run src/tools/unicode-table-generator instead of editing unicode_data.rs manually.

@rustbot

This comment has been minimized.

Sign in to view
@Jules-Bertholet

Jules-Bertholet commented Nov 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The libs team gave a positive response to the ACP. @rustbot label -S-waiting-on-ACP S-waiting-on-review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed S-waiting-on-ACP Status: PR has an ACP and is waiting for the ACP to complete. labels Nov 24, 2025
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment has been minimized.

Sign in to view
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

rustbot commented Mar 15, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rustbot rustbot removed the needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. label Mar 15, 2026
@Jules-Bertholet Jules-Bertholet mentioned this pull request Mar 15, 2026
Open
4 tasks
@rustbot rustbot removed the T-libs-api [DEPRECATED; DO NOT USE] label Mar 15, 2026
@Jules-Bertholet

Jules-Bertholet commented Mar 15, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot reroll

@rust-bors

rust-bors Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

💔 Test for 71a9f36 failed: CI

@JonathanBrouwer

JonathanBrouwer commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

@bors r-
The tests added by this PR seem to be very slow


Mon, 23 Mar 2026 00:51:27 GMT   test cell::refcell_replace ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_replace_borrows ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_swap ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_swap_borrows ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::refcell_unsized ... ok
Mon, 23 Mar 2026 00:51:28 GMT   test cell::smoketest_cell ... ok
Mon, 23 Mar 2026 00:51:29 GMT   test cell::smoketest_unsafe_cell ... ok
Mon, 23 Mar 2026 00:51:29 GMT   test cell::unsafe_cell_raw_get ... ok
Mon, 23 Mar 2026 00:51:29 GMT   test cell::unsafe_cell_unsized ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::at_most_one_case ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::ed_iterator_specializations ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::eu_iterator_specializations ... ok
Mon, 23 Mar 2026 02:55:12 GMT   test char::test_as_ascii_invalid ... ok
Mon, 23 Mar 2026 04:55:46 GMT   test char::test_char_case ... ok
Mon, 23 Mar 2026 04:55:46 GMT   test char::test_convert ... ok
Mon, 23 Mar 2026 04:55:46 GMT   test char::test_convert_const ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_decode_utf16 ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_decode_utf16_size_hint ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_encode_utf16 ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_encode_utf16_raw_buffer_too_small ... ok
Mon, 23 Mar 2026 04:55:47 GMT   test char::test_encode_utf8 ... ok
Mon, 23 Mar 2026 04:55:48 GMT   test char::test_encode_utf8_raw_buffer_too_small ... ok
Mon, 23 Mar 2026 04:55:49 GMT   test char::test_escape_debug ... ok
Mon, 23 Mar 2026 04:55:49 GMT   test char::test_escape_default ... ok

Causing hangs in the x86_64-gnu-aux job.

@rust-bors rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Mar 23, 2026
@rust-bors

rust-bors Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

This PR was contained in a rollup (#154227), which was unapproved.

@Zalathar

Zalathar commented Mar 23, 2026

Copy link
Copy Markdown
Member

Note that the x86_64-gnu-aux job runs stdlib tests under miri, making them much slower than when run normally.

Tests with many inputs/cases typically need to be excluded from miri testing, so that they don’t cause problems in that job.

@Jules-Bertholet

Jules-Bertholet commented Mar 23, 2026

Copy link
Copy Markdown
Contributor Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 23, 2026
@JonathanBrouwer

JonathanBrouwer commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

@bors try jobs=x86_64-gnu-aux

@rust-bors

This comment has been minimized.

Sign in to view
@rust-bors

rust-bors Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

☀️ Try build successful (CI)
Build commit: d8e76a8 (d8e76a8a24300a640229e839cc90c3cd6f868581, parent: bbe853615821442ef11d6cd42a30a73432b38d89)

@JonathanBrouwer

JonathanBrouwer commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

@bors r=Mark-Simulacrum

@rust-bors

rust-bors Bot commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

📌 Commit e1e903c has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 23, 2026
This was referenced Mar 23, 2026
Closed
Merged
@rust-bors
rust-bors Bot merged commit 3cad6d1 into rust-lang:main Mar 24, 2026
@rustbot rustbot added this to the 1.96.0 milestone Mar 24, 2026
@Jules-Bertholet
Jules-Bertholet deleted the titlecase branch March 24, 2026 01:51
@clarfonthey clarfonthey mentioned this pull request Mar 27, 2026
Open
@tgross35 tgross35 mentioned this pull request Mar 27, 2026
Closed
RalfJung
RalfJung reviewed Mar 27, 2026
View reviewed changes
Comment thread library/core/src/char/methods.rs
Comment on lines +892 to +893
/// Returns `true` if this `char` has the general category for titlecase letters.
/// Conceptually, these characters consist of an uppercase portion followed by a lowercase portion.

@RalfJung RalfJung Mar 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it mean to "have a category"? Something can "have a property" or "be in a category", but the wording used here doesn't seem grammatical to me.

@Jules-Bertholet Jules-Bertholet Mar 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Has the Unicode property assignment General_Category=Titlecase_Letter". But yes, "is in the general category" would probably be better

RalfJung
RalfJung reviewed Mar 27, 2026
View reviewed changes
Comment thread library/core/src/char/methods.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJung RalfJung RalfJung left review comments
@Mark-Simulacrum Mark-Simulacrum Awaiting requested review from Mark-Simulacrum

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-Unicode Area: Unicode S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.96.0

Development

Successfully merging this pull request may close these issues.

10 participants

@Jules-Bertholet @bors @rustbot @rust-log-analyzer @Mark-Simulacrum @Zalathar @JonathanBrouwer @RalfJung @m-ou-se @Dylan-DPC