Skip to content

Support Reborrow and CoerceShared built-in derives - #22325

Merged
ChayimFriedman2 merged 5 commits into
rust-lang:masterfrom
P8L1:derive-reborrow-coerce-shared
Aug 13, 2026
Merged

Support Reborrow and CoerceShared built-in derives#22325
ChayimFriedman2 merged 5 commits into
rust-lang:masterfrom
P8L1:derive-reborrow-coerce-shared

Conversation

@P8L1

@P8L1 P8L1 commented May 9, 2026

Copy link
Copy Markdown
Contributor

This adds rust-analyzer support for the experimental built-in derives Reborrow and CoerceShared.

This was split out from rust-lang/rust#156338 after review feedback that rust-analyzer changes should be made in the rust-analyzer repository rather than through the rust-lang/rust subtree.

Related:

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 9, 2026
@P8L1

P8L1 commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

r? @ChayimFriedman2

@ChayimFriedman2 ChayimFriedman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also want to wait until the rust-lang/rust PR is merged.

View changes since this review

Comment thread crates/hir-expand/src/builtin/derive_macro.rs Outdated
Comment thread crates/hir-def/src/builtin_derive.rs Outdated
Comment thread crates/hir-def/src/builtin_derive.rs Outdated
Comment thread crates/hir-ty/src/builtin_derive.rs Outdated
@P8L1
P8L1 requested a review from ChayimFriedman2 May 9, 2026 22:30

@ChayimFriedman2 ChayimFriedman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but as I said I want to wait for the rust-lang/rust PR to merge.

View changes since this review

@rustbot

This comment has been minimized.

@P8L1
P8L1 force-pushed the derive-reborrow-coerce-shared branch from 2e6a3bf to 594feb7 Compare August 13, 2026 17:23
@rustbot

rustbot commented Aug 13, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@P8L1
P8L1 requested a review from ChayimFriedman2 August 13, 2026 17:25

@ChayimFriedman2 ChayimFriedman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChayimFriedman2
ChayimFriedman2 added this pull request to the merge queue Aug 13, 2026
Merged via the queue into rust-lang:master with commit a6e4073 Aug 13, 2026
18 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants