Skip to content

kv::std_support may not need value-bag #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KodrAus merged 2 commits into from
Jun 3, 2026
+2 −1
Merged

kv::std_support may not need value-bag #729

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bc1200
kv::std_support may not need value-bag
tisonkun Jun 3, 2026
20b3b05
drop cfg-feature=kv as it is already met
tisonkun Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/kv/value.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ impl<'v> Value<'v> {
}
}

#[cfg(feature = "kv_std")]
#[cfg(all(feature = "kv", feature = "std"))]
Comment thread
tisonkun marked this conversation as resolved.
Outdated
mod std_support {
use std::borrow::Cow;
use std::rc::Rc;
Expand Down Expand Up @@ -462,6 +462,7 @@ mod std_support {
}
}

#[cfg(feature = "kv_std")]

@tisonkun tisonkun Jun 3, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may implement this for the non-value-bag Value. But that can be a follow-up.

View changes since the review

impl<'v> Value<'v> {
/// Try convert this value into a string.
pub fn to_cow_str(&self) -> Option<Cow<'v, str>> {
Expand Down
Loading