Skip to content

Fix raw debug output for negative estimated end durations #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rootkiller6788 wants to merge 1 commit into from
Closed

Fix raw debug output for negative estimated end durations #848

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/server/routes/ui/experiments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,11 @@ fn humanize(duration: Duration) -> String {
let duration = match duration.to_std() {
Ok(d) => d,
Err(_) => {
// Don't try to make it pretty as a fallback.
return format!("{duration:?}");
// A negative duration (e.g. the "estimated end" of an experiment
// whose jobs have all finished but not yet been cleaned up) can't be
// converted to a `std::time::Duration`. Report it as zero instead of
// the raw `TimeDelta { secs: -1, ... }` debug output.
return "0 seconds".to_string();
}
};
if duration.as_secs() < 60 {
Expand Down
Loading