Skip to content

toolchain specifier: we don't need the master# / try# prefix any more - #844

Merged
Mark-Simulacrum merged 2 commits into
rust-lang:masterfrom
RalfJung:toolchain-try
Jul 20, 2026
Merged

toolchain specifier: we don't need the master# / try# prefix any more#844
Mark-Simulacrum merged 2 commits into
rust-lang:masterfrom
RalfJung:toolchain-try

Conversation

@RalfJung

Copy link
Copy Markdown
Member

It was already ignored everywhere except for pretty-printing.

@Mark-Simulacrum
Mark-Simulacrum added this pull request to the merge queue Jul 20, 2026
Merged via the queue into rust-lang:master with commit 35d31b2 Jul 20, 2026
3 checks passed
@RalfJung
RalfJung deleted the toolchain-try branch July 20, 2026 14:22
@Skgland

Skgland commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Crater is showing 500 internal server error?
Could it be that it is trying (and failing) to parse existing experiments still using the old syntax?

@RalfJung

Copy link
Copy Markdown
Member Author

I assumed the parser was only used for bot commands and the database uses a structural representation. But I didn't actually check, I don't know crater that well...

@RalfJung

Copy link
Copy Markdown
Member Author

Oh yeah you are right, the database records get parsed here:

toolchains: [self.toolchain_start.parse()?, self.toolchain_end.parse()?],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants