docs: the name included in the toolchain identifier is not a branch name - #843
Merged
Merged
Conversation
RalfJung
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
RalfJung
changed the title
Member
Author
|
I have updated the PR to instead remove the references to this being "branch names". |
Mark-Simulacrum
approved these changes
Jul 20, 2026
Mark-Simulacrum
left a comment
Mark-Simulacrum
left a comment
Member
There was a problem hiding this comment.
I think we should be able to get rid of this entirely but that can be follow up work - will need some code changes as well. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know why crater needs to know whether the toolchain comes from
masterortry(when I download the toolchain with rustuo-toolchain-install-master, I just need a commit and it works the same for master and try builds) -- but it's definitely confusing to say that these are branch names when actually they identify some part of the URL the toolchain is downloaded form, or whatever else crater does with this.