docs(ch04-02): clarify reference scope vs variable scope (#4706) - #4778
Open
Dodothereal wants to merge 1 commit into
Open
docs(ch04-02): clarify reference scope vs variable scope (#4706)#4778Dodothereal wants to merge 1 commit into
Dodothereal wants to merge 1 commit into
Conversation
Fixes rust-lang#4706: the phrase 'a reference's scope starts from where it is introduced' implicitly shifts the meaning of the word 'scope' from the lexical (curly-bracket) scope used for variables to the non-lexical lifetime-style scope used for references. Without acknowledging the shift, beginners may conflate the two. Prepend one sentence to the existing paragraph to make the distinguishing factor explicit.
Contributor
Author
|
Hi, just a gentle ping on this in case it slipped through - no rush at all. Happy to rebase, split, or adjust anything if that helps. Thanks for maintaining this project. |
|
Hi, according to contributing note, "it may take longer than you're used to for us to address your issue or pull request." because they "want to keep the online version of the book close to the print version when possible" I've seen you made several new PRs(including other issues) which are duplicated, it would be better to comment on their PR if you have better suggestions, since there are plenty of works to do of maintainers as you said |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4706
Summary
Chapter 4-2 introduces a non-lexical-lifetime-style scope for
references but does not flag the shift away from the lexical scope
used for variables in earlier chapters. Beginners coming from
other languages may conflate the two meanings.
This commit prepends one sentence that makes the distinction
explicit, leaving the substantive explanation unchanged.
Test plan
AI assistance
Prepared with help from an AI coding assistant.