Gate access_kind_for_place_use AccessKind::Move rule on !prove_ty_is_copy - #448
Open
jackh726 wants to merge 2 commits into
Open
Gate access_kind_for_place_use AccessKind::Move rule on !prove_ty_is_copy#448jackh726 wants to merge 2 commits into
jackh726 wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for contributing to formality! :) |
nikomatsakis
requested changes
Aug 12, 2026
| ) | ||
|
|
||
| ( | ||
| (if !prove_ty_is_copy(env, assumptions, state, &place.ty).is_proven())! |
Contributor
There was a problem hiding this comment.
Yeah I feel like this should not be needed, I want to look into this more closely.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
See the two added tests: the AccessKind::Move rule was being used even when ty is copy.
Question: as @nikomatsakis pointed out to me, it's a bit surprising that the
Copyrule doesn't result in a successful program despite theMoverule being selected (i.e. we should try both).As for to_rust, use
statusfor cargo fmt, notspawn(the former is blocking on the result, the latter is not).AI disclosure