add: optional-fn-return-type

[xonx4l]

What does this PR do?

This PR implements optional function return type as discussed in #393

e.g., closes #393

How does it work, what questions do you have?

Functions can now be written fn foo() { } instead of requiringfn foo() -> () { }. When the return type is omitted, it defaults to the unit type ().

Added tests demonstrating that fn run() {trusted} parses identically tofn run() -> () {trusted}.

AI disclosure

• I did not use any AI tools

[rustbot]

Thanks for contributing to formality! :)
A reviewer will take a look at your PR within a week or two. If not, come talk to us on https://rust-lang.zulipchat.com/#narrow/channel/402470-t-types.2Fformality

[nikomatsakis]

Nice work! I have one suggested improvement

View changes since this review

[nikomatsakis]

Suggested change

	let rest: Vec<TokenStream> =
	chars.map(|c| quote!(__p.expect_char(#c)?;)).collect();
	(quote!(__p.expect_char(#first).is_ok()), quote!(#(#rest)*))
	(
	quote!(__p.expect_char(#first).is_ok()),
	quote!(#(__p.expect_char(#chars)?;)*)
	)

I think maybe maybe you can just do this?

[nikomatsakis]

Hmm, I am not sure if we want a default for Ty that is always unit. It's convenient here but it might not be correct elsewhere. Let's have a new type like

struct OutputTy { ty: Ty }

impl Upcast<Ty> for OutputTy { }

impl Default for OutputTy { }

and then change output_ty: OutputTy

[xonx4l]

Ok , will do . Thanks!

[nikomatsakis]

(Still waiting for change to have an OutputTy that carries the Default impl.)

View changes since this review

[xonx4l]

@nikomatsakis I am sorry , I really got a bit busy and forgot about this . I will try to implement the suggested changes asap. Thank you!

[nikomatsakis]

@xonx4l no worries!

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[xonx4l]

@nikomatsakis sorry it took a while , made all the requested changes . Thank you!