Added ability to manipulate HTML-attributes with AST - #483
Open
temapavloff wants to merge 5 commits into
Open
Conversation
Collaborator
|
I love the idea! Let me sit on it for a few days to let the API design to sink in... Thanks! |
Contributor
|
While it would be cool to do something like the above, I don't think changing the AST is a good idea. What I want to do with Blackfriday in Hugo is to parse once, render many. Adding HTML specific AST mods will break that. I think your approach could work if you somehow managed to create a copy of the node you want to "override". Also, note that you don't have implement a full renderer to manipulate single nodes, as shown in my quick test repo below: that https://github.com/bep/blackfriday-v2-test You will end up with byte manipulation, which is less clean, but certainly possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose: make possible to change output HTML attributes without re-implementing whole renderer.
For example, I want to add extra class to paragraphs which contains images. Now I can do it simply analyzing and changing AST before rendering content: