Skip to content

Add config for right-to-left progress (for RTL languages) - #143

Open
ian-craig wants to merge 1 commit into
rstacruz:masterfrom
ian-craig:support-rtl
Open

ian-craig wants to merge 1 commit into
rstacruz:masterfrom
ian-craig:support-rtl

Conversation

@ian-craig

Copy link
Copy Markdown

To properly support RTL languages like Hebrew, the progress should be able to animate right-to-left.

This adds an option to configure the progress bar to be RTL:

rtl

Change the progress direction to right-to-left. (default: false)

NProgress.configure({ rtl: true });

@oliviertassinari

Copy link
Copy Markdown

@rstacruz Any plan on support right-to-left? :)

@drinkmaker

Copy link
Copy Markdown

This solution works perfectly #206

@shayaulman

Copy link
Copy Markdown

@rstacruz , is there any chance that this PR will be merged soon?

This solution works perfectly #206

The issue is about adding a rtl option to the config.
(besides that editing the node modules directly is never a [perfect] solution).

@Iliyass

Iliyass commented Oct 13, 2021

Copy link
Copy Markdown

this PR should be merged! @ian-craig thank you for your contribution.

@mhaneef50673

Copy link
Copy Markdown

@Iliyass Any idea when this PR will be merged?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants