Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 变更摘要
Keep this PR in draft until Modern.js publishes a compatible addon and the release checks below pass. 等待 Modern.js 发布兼容版本并完成下方验证后再合并。 Modern.js PR #9205
storybook-addon-modernjsfrom the workspace and release set. Retire the React integration tests and their test-only config now covered upstream.@modern-js/storybook-addon@latestand depend directly on the v4 workspace builder. Keep the separate federated-remote browser test.@modern-js/storybook-addon@latest,并显式依赖工作区的 v4 builder。继续测试浏览器从远端加载联邦组件。Compatibility
The upstream fixture registers
appTools()andbffPlugin(). The addon calls the publicresolveModernRsbuildConfig({ command: 'storybook' }), merges shared andclientsettings, and calls the builder’sstripInheritedConfig. With the current example lock (@modern-js/app-tools@3.10.0), that resolver returned the React example’s@my-srcalias. Both examples loaded the preset with the v4 workspace builder. Upstream fixture · Upstream presetThe current upstream builder peer is
~3.6.3. This branch uses4.0.0-beta.0with Storybook11.0.0-beta.3. The addon also requests Rsbuild^2.3.2and the matching Modern.js app-tools release. The examples currently lock Rsbuild2.2.13. Confirm published peer support before merging. Upstream peer dependenciesLocal validation
Built the addon from Modern.js commit
8045619and placed its package files in the two examples’ localnode_modulesfor runtime checks. The local checkout used this branch’s builder and framework throughout.pnpm check,pnpm check-dependency-versionandpnpm --filter website buildpassed.pnpm build:sandboxesbuilt all 13 Storybooks. The React example also rendered the AntdButton docs and themyButtonExtraprop in Chrome using its dev server.pnpm testpassed all 232 tests.pnpm build:testpassed.pnpm e2e --retries=0 --workers=3passed all 23 tests, including the Module Federation host loading RemoteButton. The normalpnpm buildpassed afterward.Before merging / 合并前
@modern-js/storybook-addonon the npmlatesttag whose builder peer includes v4. Align the Modern.js and Rsbuild resolutions with the published peer ranges.pnpm installand commit the resultingpnpm-lock.yaml. The current lockfile prunes the retired workspace package and links the examples to the local builder. The new package is still missing from npm (ERR_PNPM_FETCH_404), so a clean frozen install currently reportsERR_PNPM_OUTDATED_LOCKFILE.pnpm install --frozen-lockfile, rerun the checks above with the registry package, and confirm both examples before marking this PR ready.