Skip to content

chore(deps): bump storybook to 11.0.0-beta.3 - #649

Merged
fi3ework merged 1 commit into
v4from
chore/v4-sync-sb11-beta3
Nov 19, 2026
Merged

fi3ework merged 1 commit into
v4from
chore/v4-sync-sb11-beta3

Conversation

@fi3ework

Copy link
Copy Markdown
Member

Summary

Bump storybook and @storybook/* from 11.0.0-beta.1 to 11.0.0-beta.3 on v4, align packages/*/peerDependencies.storybook to ^11.0.0-beta.3, and adapt the beta.3 checkBuilderDocgenPackages signature change:

 packages/framework-react/src/builder-docgen.ts
+const REACT_DOCGEN_TYPESCRIPT_APIS: readonly TypeScriptDocgenApi[] = ['compiler', 'native']
+
 export async function prepareReactBuilderDocgen({ reactDocgen, resolve, options }: {
   reactDocgen: Exclude<ReactDocgenConfig, false>
   resolve: (specifier: string) => string
-  options: Pick<Options, 'configDir'>
+  options: Pick<Options, 'configDir' | 'presets'>
 }) {
   const missing = await checkBuilderDocgenPackages({
     ...,
+    apis: REACT_DOCGEN_TYPESCRIPT_APIS,
   })
 }

Also:

  • .agents/skills/storybook-check/manifest.json: record why REACT_DOCGEN_TYPESCRIPT_APIS is mirrored locally (@storybook/react exports map does not expose docgen-typescript-apis.ts).
  • packages/builder-rsbuild/src/chromatic-stats.ts: leave a TODO comment noting the deferred TurboSnap watch-file dependency capture gap (builder-vite commit 8bc0826db47a9fdda453613bb62da3494aab2153), with no runtime logic changes.

Evidence

  • Before: Installing 11.0.0-beta.3 failed storybook-react-rsbuild build/type-check because checkBuilderDocgenPackages now requires options: Pick<Options, 'configDir' | 'presets'> and accepts apis.
  • After:
    • pnpm install — exit 0
    • pnpm check-dependency-version — exit 0 (No dependency version mismatches found.)
    • pnpm check (lint + type-check + format) — exit 0
    • pnpm exec rstack test packages/framework-react packages/builder-rsbuild — exit 0 (149 passed, including new typescript.docgenSpecifier unit test in packages/framework-react/tests/builder-docgen.test.ts)
    • pnpm test (after building sandboxes/react-18) — exit 0 (232 passed)
    • pnpm --filter storybook-react-rsbuild build & pnpm --filter storybook-builder-rsbuild build — exit 0

Merge Danger

Door: Two-way

Standard prerelease dependency bump + small type/argument adaptation on v4; easy to revert.

Blast Radius: Low

Narrows packages/*/peerDependencies.storybook from ^11.0.0-beta.1 to ^11.0.0-beta.3 (required by pnpm check-dependency-version to stay byte-equal with @storybook/* renderers). No runtime behavior changes outside React builder docgen diagnostics.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T07:59:59.788958Z 393c1fd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fi3ework
fi3ework merged commit a588967 into v4 Nov 19, 2026
5 checks passed
@fi3ework
fi3ework deleted the chore/v4-sync-sb11-beta3 branch November 19, 2026 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant