Repository navigation
Release v1.3.0: macOS/Linux support and archive fixes - #20
Merged
Merged
Conversation
rozx
added
the
release
This was referenced Sep 24, 2026
Windows chmod does not set POSIX execute bits. Assert that tar packaging preserves the source file mode on each host.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)SUGGESTION
Files Reviewed (17 files, incremental since 3840073)
All 9 previously reported findings were addressed: 7 fixed in ed0f823, duplicate release builds documented as an intentional tradeoff, and Previous Review Summary (commit 3840073)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 3840073)Status: 9 Issues Found | Recommendation: Address before merge Overview
Fix these issues in Kilo Cloud Issue Details (click to expand)WARNING
SUGGESTION
Files Reviewed (72 changed files; engine binaries excluded)
Reviewed by glm-5.3 · Input: 0 · Output: 0 · Cached: 0 |
| throw new Error('Uploaded asset checksums differ; keeping the release as a draft'); | ||
| } | ||
| await assertTag(); | ||
| // Let GitHub choose Latest by creation date and semantic version, rather than |
There was a problem hiding this comment.
SUGGESTION: Comment describes smart semantics, but make_latest: 'legacy' selects Latest by creation date only
Per the linked docs, legacy marks the release with the most recent creation date as Latest; "creation date and semantic version" is the definition of smart (the API default). The legacy choice itself is sound here — a resumed publish of an older version cannot steal Latest because its draft was created earlier — but the comment justifies it with behavior legacy does not have. The practical difference: under legacy, a later-finishing older release (e.g. a v1.2.x backport) would take the Latest badge from v1.3.0; smart would not. Either fix the wording or switch to 'smart' (and update the pinned assertion in tests/test_publish_release.py).
Suggested change
| // Let GitHub choose Latest by creation date and semantic version, rather than | |
| // Let GitHub choose Latest by the most recent creation date, rather than |
Reply with @kilocode-bot fix it to have Kilo Code address this issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release 1.3.0 adds native macOS and Linux support alongside Windows and updates the bundled 7-Zip engines to 26.03. Platform assets now live in separate directories, including
7z/windows-x64/.release/*PR merging intomain, using version-matched notes fromReleaseNotes/and verified download checksums.Validation
poetry run buildproduced the macOS ARM64 standalone executable.Fixes #17
Fixes #18
Fixes #19