Repository navigation
fix: prevent PDF preview loading-state race - #1172
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A PDF iframe can load before the viewer’s passive effect runs. That effect then resets the completed preview to “Loading PDF…”, causing the failure in main CI run #1198 and potentially leaving a fast-loading preview covered by its loading overlay.
Reset the viewer state by keying the stateful component to the file path instead of resetting it in an effect. Switching files still starts a fresh loading state, and events from an old iframe cannot update the new preview.
Validation:
NODE_OPTIONS=--no-experimental-webstorage npm test -- --maxWorkers=4).