Repository navigation
x: hide sidebar account popovers while the sidebar is collapsed - #1166
Open
replicas-connector[bot] wants to merge 2 commits into
Open
replicas-connector[bot] wants to merge 2 commits into
replicas-connector[bot] wants to merge 2 commits into
Conversation
The sidebar collapses offcanvas, so the plan card and credit-rewards pill slide off-screen and any popover anchored to them (out of credits, earn credits) was cut off at the window edge. Keep the open state but only show the popover while the sidebar is expanded, so an out-of-credits auto-open appears once the sidebar is reopened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: arkml <6592213+arkml@users.noreply.github.com> Co-Authored-By: replicas-connector[bot] <replicas-connector[bot]@users.noreply.github.com>
The first pull_request run stayed queued with no jobs and could not be cancelled or re-run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: arkml <6592213+arkml@users.noreply.github.com> Co-Authored-By: replicas-connector[bot] <replicas-connector[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Collapsing the sidebar slides it off-canvas. The out-of-credits popover (plan card) and the earn-credits popover (rewards pill) are anchored to elements in the sidebar footer, so they followed their anchor off the left edge and showed cut off.
Fix
Both popovers now render
open={open && !sidebarCollapsed}. The open state is kept, so the out-of-credits popover that auto-opens when credits run out appears when the sidebar is expanded again instead of half off-screen.sidebar-content.tsx: out-of-credits popoversidebar-credit-rewards.tsx: earn-credits popoverVerification
tsc -binapps/x/apps/rendererpasses.Requested by Arjun Maheswaran, https://rowboat.spaces.x.rowboatlabs.com/s/01M0HWBJR0KSG04PWM4411N29X/m/01M4BE4WA49GHAX81962MKE753
🤖 Generated with Claude Code