Repository navigation
feat(spaces): add desktop browsing and joining for open spaces - #1133
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harbor supports open spaces after #1121, but the desktop app still assumes that a space must be joined before it can be opened. This PR lets team members browse open spaces, read their content without joining, and explicitly join when they want to participate.
For example, opening a message or file link in an unjoined open space now shows the requested content with a Join space prompt. Joining enables member controls and adds the space to the sidebar without losing the selected content.
User-facing changes
Access and live-state handling
Preview access is distinct from membership throughout the renderer. Mutation guards cover retained callbacks and delayed sends as well as visible controls, so losing membership cannot leave an active write action behind.
Preview traffic does not create personal read marks, follows, or outgoing presence. Whiteboards use view mode and suppress outgoing scene, cursor, scene-request, and save operations while continuing to receive updates. Active previews subscribe to live content and recover after reconnect; joined spaces retain their existing background behavior.
Membership changes refresh the roster and directory. Removal immediately disables member actions and clears pending personal read state, then revalidates access and resubscribes if the space remains readable. Revision checks prevent stale responses from replacing newer membership state.
Transport and documentation
Validation
Completed during implementation:
NODE_OPTIONS=--no-experimental-webstorage npm test -- --run --maxWorkers=4.git diff --checkpassed again before committing.The renderer command disables Node 26's native WebStorage so the suite uses its jsdom storage implementation. An unrelated PDF preview test failed in an earlier parallel run, then passed in isolation and in the final full run; no PDF code was changed.
The real Harbor client integration tests and server integration suite were blocked in the earlier sandbox by socket/network-interface permission errors (
listen EPERManduv_interface_addresses EPERM). They are not claimed as passing. Live two-account, packaged-app, and visual smoke tests have not been executed; the manual cases are prepared for that review.Manual review priorities
Rollout and scope
This is the desktop UI follow-up to #1121 and consumes its additive server APIs. Deploy Harbor support before using the new app features; no coordinated deployment or database migration is introduced here. Existing member workflows and private creation remain supported on older servers.
No new Harbor product rule or wire contract is introduced. Team invites, profiles, admin controls, archive/delete, and mobile UI remain separate work.