Fix Mbox export not quoting body lines starting with "From " (#10150) - #10288
Open
AR-Sebastian wants to merge 1 commit into
Open
Fix Mbox export not quoting body lines starting with "From " (#10150)#10288AR-Sebastian wants to merge 1 commit into
AR-Sebastian wants to merge 1 commit into
Conversation
…be#10150) The zipdownload Mbox stream filter quoted a "From " line only when it appeared at the very start of a stream bucket. Message bodies, however, are written to the stream in large chunks (rcube_imap_generic::handlePartBody() writes up to 1 MB at a time), not line by line, so interior "From " lines were never quoted, producing a corrupt Mbox where those lines could be misread as message delimiters. Buffer the data across chunks and quote every complete line matching /^>*From /, keeping any incomplete trailing line for the next chunk and flushing it on close. Add a regression test covering single-chunk and byte-by-byte writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zipdownload Mbox stream filter quoted a "From " line only when it appeared at the very start of a stream bucket. Message bodies, however, are written to the stream in large chunks (rcube_imap_generic::handlePartBody() writes up to 1 MB at a time), not line by line, so interior "From " lines were never quoted, producing a corrupt Mbox where those lines could be misread as message delimiters.
Buffer the data across chunks and quote every complete line matching /^>*From /, keeping any incomplete trailing line for the next chunk and flushing it on close. Add a regression test covering single-chunk and byte-by-byte writes.