-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Setting up Turtlesim - how-to #6935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kacperbojakowski-3di
wants to merge
12
commits into
ros2:rolling
Choose a base branch
from
kacperbojakowski-3di:setting-up-turtlesim-howto
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−137
Open
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
b849ab2
Update Setting up turtlesim how-to
kacperbojakowski-3di 20de3f6
Implement peer review feedback
kacperbojakowski-3di 0898950
Merge branch 'rolling' of upstream into setting-up-turtlesim-howto
kacperbojakowski-3di c26469d
Peer review updates to Turtlesim topic
dmarshant 62f117f
Merge branch 'rolling' into setting-up-turtlesim-howto
dmarshant ddec86c
Peer review update
kacperbojakowski-3di 1f8c7d6
Merge branch 'setting-up-turtlesim-howto' of https://github.com/3di-f…
kacperbojakowski-3di 43f4be8
Update Introducing-Turtlesim.rst
kacperbojakowski-3di 8404b2f
Merge remote-tracking branch 'upstream/rolling' into setting-up-turtl…
kacperbojakowski-3di 27b29d0
Implement SME feedback
kacperbojakowski-3di 152ebd0
Merge remote-tracking branch 'upstream/rolling' into setting-up-turtl…
kacperbojakowski-3di 00019e9
Fix links
kacperbojakowski-3di File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like I said, I know we're simply following the previous material but this is really unsatisfying. There's no definition of what we mean by
remappingor why we would have to do that to control a second turtle. If we're going to update this page we should aim for it to more informative than it was before.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kscottz Thanks! That was indeed too sparse and vague, I should have noticed. Fixed now, hopefully – let me know.