-
Notifications
You must be signed in to change notification settings - Fork 1.3k
3di | Triaging and reporting an issue #6901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
keithkirkwood-3di
wants to merge
16
commits into
ros2:rolling
Choose a base branch
from
3di-for-openrobotics:triaging-reporting-an-issue
base: rolling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+190
−94
Open
Changes from 12 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
6fa317c
OPENR-98: Create article for triaging an issue
keithkirkwood-3di 1aa5e82
OPENR-146: Create article for reporting an issue and update triaging
keithkirkwood-3di 610fb39
Merge branch 'ros2:rolling' into triaging-reporting-an-issue
keithkirkwood-3di 2315163
OPENR-146: Fix link issue for linter and add sentence to summary
keithkirkwood-3di 4f0e136
Merge branch 'rolling' into triaging-reporting-an-issue
kscottz 2b07915
Merge branch 'ros2:rolling' into triaging-reporting-an-issue
keithkirkwood-3di 3b38267
OPENR-146: Updates to Reporting an issue from PR comments
keithkirkwood-3di a2152d9
Update source/The-ROS2-Project/Contributing/Contributing-to-code/Tria…
kscottz a43e6cf
OPENR-98: Action comments for Triaging and tidy up
keithkirkwood-3di 6a202bf
Merge branch 'rolling' into triaging-reporting-an-issue
keithkirkwood-3di abb63f9
OPENR-98: Fix typo in Triaging
keithkirkwood-3di 6c009a1
Merge branch 'triaging-reporting-an-issue' of https://github.com/3di-…
keithkirkwood-3di e9b4840
Merge branch 'rolling' into triaging-reporting-an-issue
kscottz ebebb50
Merge branch 'rolling' into triaging-reporting-an-issue
gbiggs 9d0d0b9
Correct broken references
gbiggs 90aac6c
Merge branch 'rolling' into triaging-reporting-an-issue
gbiggs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
source/The-ROS2-Project/Contributing/Contributing-to-code.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| Contributing to code | ||
| ==================== | ||
|
|
||
| .. toctree:: | ||
| :maxdepth: 1 | ||
|
|
||
| Contributing-to-code/Triaging-an-issue | ||
| Contributing-to-code/Reporting-an-issue |
111 changes: 111 additions & 0 deletions
111
source/The-ROS2-Project/Contributing/Contributing-to-code/Reporting-an-issue.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| Reporting an issue — how-to | ||
| =========================== | ||
|
|
||
| Issue reports help the ROS community identify bugs, suggest enhancements, improve documentation, and resolve package-specific problems. | ||
| This article explains how to check whether an issue has already been reported and what information to provide in a new issue. | ||
| With this information, you can provide clear, complete issue details in the right ROS repository. | ||
|
|
||
| **Area: community | Content-type: how-to | Experience: beginner, intermediate, expert** | ||
|
|
||
| .. contents:: Table of Contents | ||
| :depth: 2 | ||
| :local: | ||
|
|
||
| Summary | ||
| ------- | ||
|
|
||
| * **Code issue trackers**: in a repository under the `ROS organisation <https://github.com/orgs/ros2/repositories>`__ or elsewhere on GitHub. | ||
| * **Documentation issue tracker**: `ROS documentation repository <https://github.com/ros2/ros2_documentation/issues>`__. | ||
| * **Catch-all issue tracker**: `top level ROS repository <https://github.com/ros2/ros2/issues>`__. | ||
|
|
||
| Prerequisites | ||
| ------------- | ||
|
|
||
| There are no prerequisites. | ||
|
|
||
| Steps | ||
| ----- | ||
|
|
||
| 1 Identifying where to report the issue | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| If you identify a bug, have a suggestion for enhancement, or a question specific to one package, you can report an issue on GitHub. | ||
| For example, if you are following the :doc:`/Tutorials` and come across an instruction that doesn't work on your system, you can report an issue in the `ROS documentation repository <https://github.com/ros2/ros2_documentation/issues>`__. | ||
|
|
||
| You can report code issues in the ROS repository for the package where the error occurred. | ||
| This is generally the last file listed in the stack trace. | ||
|
|
||
| You can search for ROS packages in the following locations: | ||
|
|
||
| * Core ROS 2 packages, found in the `ROS organisation <https://github.com/ros2>`__ | ||
| * ROS binary packages, found on the `ROS Index <index.ros.org>`__, which point to the appropriate GitHub repository. | ||
| * Source ROS packages which are located elsewhere on GitHub. | ||
|
|
||
| If it's not clear which issue tracker to use for a particular issue, report the issue in the `top-level ROS repository <https://github.com/ros2/ros2/issues>`__ and we'll have a look at it. | ||
|
|
||
| 2 Checking the issue | ||
| ^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| Before opening an issue: | ||
|
|
||
| #. Check if other users have reported similar issues by searching across the ``ros2`` and ``ament`` GitHub organizations using, for example, this `search query <https://github.com/search?q=user%3Aros2+user%3Aament+turtlesim&type=Issues>`__. | ||
| #. Check the `Robotics Stack Exchange <https://robotics.stackexchange.com/>`__ to see if someone else has already reported your issue. | ||
|
|
||
| If your issue has not been reported, you can open an issue in the issue tracker of the repository you have identified. | ||
|
|
||
| 3 Reporting the issue | ||
| ^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| When reporting an issue, use the following steps to make sure you include enough information for another person to understand and (where relevant) reproduce the issue. | ||
|
|
||
| #. In the issue tracker of your selected repository, select **New issue**. | ||
| #. From the options shown, select the issue type which is most appropriate for the issue you are raising: | ||
|
|
||
| * If you are in a ROS code repository or the top-level ROS repository, select **Bug report** or **Feature request**. | ||
| * If you are in the ROS documentation repository, select **Documentation issue**. | ||
| * Alternatively, if the specific ROS repository you are in has a unique issue template, you can use that instead. | ||
|
|
||
| #. Add a descriptive **Title** for the issue. | ||
|
|
||
| **Bad**: "rviz doesn't work". | ||
|
|
||
| **Good**: "Rviz crashing looking for missing ``.so`` after latest apt update" | ||
|
|
||
| #. Complete the remaining fields in the issue template, following the prompt text shown and the formatting of any pre-filled fields. | ||
|
|
||
| Additional information | ||
| """""""""""""""""""""" | ||
|
|
||
| * If you are reporting a bug, consider providing a `short, self contained, correct (compilable) example <https://sscce.org/>`__. | ||
| * When discussing any compiling/linking/installation issues, provide the version number of your compiler. | ||
| * If relevant to your issue, you can also include your: | ||
|
|
||
| * ROS environment variables (``env | grep ROS``) | ||
| * Backtraces | ||
| * Relevant config files | ||
| * Graphics card model and driver version | ||
| * ``Ogre.log`` for rviz, if possible (run with ``rviz -l``) | ||
| * Bag files and code samples which reproduce the problem | ||
|
keithkirkwood-3di marked this conversation as resolved.
|
||
| * GIFs or video clips to demonstrate the problem | ||
| * Log files (see :doc:`/Concepts/Intermediate/About-Logging`) or logs from the RQT console (see :doc:`/Tutorials/Beginner-CLI-Tools/Using-Rqt-Console/Using-Rqt-Console`) | ||
|
|
||
| * Also describe any troubleshooting which you have already attempted, for example: | ||
|
|
||
| * Upgrading to the latest version of the code, which may include bug fixes that have not been released yet. | ||
|
|
||
| For more information, see :ref:`building-from-source` and follow the instructions to get the ``rolling`` branch. | ||
|
|
||
| * Trying to reproduce your issue with a different RMW implementation. | ||
|
|
||
| For more information, see :doc:`/How-To-Guides/Working-with-multiple-RMW-implementations`. | ||
|
|
||
| Related content | ||
| --------------- | ||
|
|
||
| * :doc:`../../Contributing` | ||
| * :doc:`Triaging-an-issue` | ||
|
|
||
| FAQs | ||
| ---- | ||
|
|
||
| TBC | ||
77 changes: 77 additions & 0 deletions
77
source/The-ROS2-Project/Contributing/Contributing-to-code/Triaging-an-issue.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| Triaging an issue — how-to | ||
| ========================== | ||
|
|
||
| Issue triage helps ROS contributors turn incoming bug reports and enhancement requests into clear, actionable work. | ||
| This article explains how to find, check, reproduce, assign, and label issues in ROS repositories. | ||
| With this information, you'll be able to route issues to the right place, with correct information, and prepare them for work by developers. | ||
|
|
||
| **Area: community | Content-type: how-to | Experience: beginner, intermediate, expert** | ||
|
|
||
| .. contents:: Table of Contents | ||
| :depth: 2 | ||
| :local: | ||
|
|
||
| Summary | ||
| ------- | ||
|
|
||
| We welcome anyone to triage issues. | ||
|
|
||
| * **Code issue trackers**: in a repository under the `ROS organisation <https://github.com/orgs/ros2/repositories>`__ or elsewhere on GitHub. | ||
| * **Documentation issue tracker**: `ROS documentation repository <https://github.com/ros2/ros2_documentation/issues>`__. | ||
| * **Catch-all issue tracker**: `top level ROS repository <https://github.com/ros2/ros2>`__. | ||
|
|
||
| Prerequisites | ||
| ------------- | ||
|
|
||
| There are no prerequisites. | ||
|
|
||
| Steps | ||
| ----- | ||
|
|
||
| 1 Finding an issue to triage | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| We encourage contributors to look at incoming issues on ROS repositories and triage the problems that users are having: | ||
|
|
||
| * To find code issues for triage, review the issues list of a repository under the `ROS organization <https://github.com/orgs/ros2/repositories>`__, for example the issues list in the `ROS CLI repository <https://github.com/ros2/ros2cli/issues/>`__. | ||
| * To find documentation issues for triage, review the issues list in the `ROS documentation repository <https://github.com/ros2/ros2_documentation>`__. | ||
| * If you're not sure where to start, review the issues list in the `top level ROS repository <https://github.com/ros2/ros2>`__. | ||
|
|
||
| When you have identified an issue for triage, add a comment to the issue to say that you are looking into it. | ||
|
|
||
| 2 Confirming and reproducing the issue | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| When you have found an issue to triage, confirm that the issue is genuinely an issue (a bug or a request for enhancement) and has been created with the expected information. | ||
|
|
||
| For more information about the information the reporter of the issue is expected to provide, see :doc:`./Reporting-an-issue`. | ||
|
|
||
| #. If the issue ``Description`` is actually posing a question, close the issue and add a comment directing the user to the `Robotics Stack Exchange <https://robotics.stackexchange.com/>`__ to get help with their question. | ||
| #. If the issue looks like a genuine issue (bug or enhancement), but is not relevant to the repository it has been raised in, transfer the issue to the appropriate ROS repository (`see the GitHub documentation for guidance about how to transfer between repositories <https://docs.github.com/en/issues/tracking-your-work-with-issues/administering-issues/transferring-an-issue-to-another-repository>`__). | ||
|
kscottz marked this conversation as resolved.
|
||
| #. If the issue appears to be a valid but lacks sufficient details to replicate the environment (for example, the host operating system, platform, RMW implementation, ROS distro, and offending code) please request that author provide additional information. | ||
| #. If the issue is a bug, try to reproduce the bug using the provided steps — if you cannot reproduce the bug, add a comment to the reporter asking for clarification. | ||
|
|
||
| 3 Assigning and labelling the issue | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
|
||
| After you've confirmed the issue is a genuine issue, and reproduced it, assign and label the issue appropriately to allow work on the issue to begin by a developer. | ||
|
keithkirkwood-3di marked this conversation as resolved.
|
||
|
|
||
| #. Assign the issue to the maintainer for the ROS repository in question. | ||
| #. Label the issue as a ``bug`` or ``enhancement``, as appropriate. | ||
| #. If this issue is a request for a new feature, label the issue with ``help-wanted``. | ||
| #. If the reporter has not provided enough information to determine the cause of the problem, label the issue as ``more-information-needed`` and leave a comment for the reporter, including: | ||
|
|
||
| * What you have tried while investigating the problem. | ||
| * In what way the information supplied was insufficient. | ||
| * Any suggestions you may have about what additional information is needed. | ||
|
|
||
| Related content | ||
| --------------- | ||
|
|
||
| * :doc:`../../Contributing` | ||
| * :doc:`Reporting-an-issue` | ||
|
|
||
| FAQs | ||
| ---- | ||
|
|
||
| TBC | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.