Skip to content

Drop unnecessary mutex lock in .event_mgr() #996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roncapat wants to merge 2 commits into
base: rolling
Choose a base branch
from
+0 −3
Open

Drop unnecessary mutex lock in .event_mgr() #996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfd6a62
Drop unnecessary mutex lock in `.event_mgr()`
roncapat Jun 16, 2026
618b92d
Drop `SubscriptionData::graph_cache()` mutex use
roncapat Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion rmw_zenoh_cpp/src/detail/rmw_publisher_data.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,7 +800,6 @@ bool PublisherData::liveliness_is_valid() const
///=============================================================================
std::shared_ptr<EventsManager> PublisherData::events_mgr() const
{
std::lock_guard<std::mutex> lock(mutex_);
return events_mgr_;
}

Expand Down
2 changes: 0 additions & 2 deletions rmw_zenoh_cpp/src/detail/rmw_subscription_data.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,6 @@ bool SubscriptionData::liveliness_is_valid() const
///=============================================================================
std::shared_ptr<EventsManager> SubscriptionData::events_mgr() const
{
std::lock_guard<std::mutex> lock(mutex_);
return events_mgr_;
}

Expand Down Expand Up @@ -1187,7 +1186,6 @@ void SubscriptionData::set_on_new_message_callback(
//==============================================================================
std::shared_ptr<GraphCache> SubscriptionData::graph_cache() const
{
std::lock_guard<std::mutex> lock(mutex_);
return graph_cache_;
}

Expand Down
Loading