Repository navigation
Regenerate Java client from latest OpenAPI spec and publish Release Drafter drafts - #74
Merged
Merged
Conversation
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…lights Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Hchanni
approved these changes
Oct 7, 2026
This was referenced Oct 7, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regenerates the client with the Makefile's pinned
openapitools/openapi-generator-cli:v7.13.0. It covers models, APIs, docs, tests andapi/openapi.yaml.API changes
Post-processing note: the Makefile's post-generation edits use BSD
sed -i ''. On GNU/Linux that silently no-ops, because it's masked by|| true. The same edits were applied here with GNUsed -i: theInstantparsing inJSON.java, and removing theObject.validateJsonElement/UUID.validateJsonElementcalls. The Makefile itself is unchanged.spotlessApplywas intentionally not run:enforceCheck falseis set, and master's generated code was never formatted.Release flow, aligned with rootly-ts / rootly-swift
publish.ymlnever created a GitHub release, though CLAUDE.md and PUBLISHING.md said it did. A newreleasejob runs after the Maven Central and GitHub Packages publish. It checks out the repo and fetches the annotated tag. It then promotes the most recent Release Drafter draft, whatever tag the draft resolved to, and renames it to the pushed tag. The annotated tag message is prepended under## Highlights. Without a draft, it falls back togh release create --verify-tag --generate-notes. This is the logic rootly-swift used for v2.0.0. rootly-ts got the same fix in rootly-ts#43 after itsv0.4.0release job failed on a tag-name mismatch.release-drafter.ymlusesv$RESOLVED_VERSIONwith the ts version resolvers (breaking→ major,enhancement→ minor).CHANGELOG.mdnow points to GitHub Releases. Earlier entries are kept under "Older releases".Validation:
./gradlew test --no-daemonpasses (10,228 tests, 0 failures, 611 skipped).mvn -B packagepasses. actionlint reports no new findings; the only one is the existing unknownblacksmith-*runner label.Risk: low. This is a generated SDK refresh plus release-workflow changes. Consumers of the removed endpoints break when they upgrade, so the release should be a major bump.
Link to Devin session: https://rootly.devinenterprise.com/sessions/af696ad13f4e47a09908c76ef0b67191
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/af696ad13f4e47a09908c76ef0b67191?variant=devin
Requested by: @kwent