Skip to content

Regenerate Java client from latest OpenAPI spec and publish Release Drafter drafts - #74

Merged
kwent merged 3 commits into
masterfrom
devin/1791355339-regenerate-client
Oct 7, 2026
Merged

kwent merged 3 commits into
masterfrom
devin/1791355339-regenerate-client

Conversation

@kwent

@kwent kwent commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Summary

Regenerates the client with the Makefile's pinned openapitools/openapi-generator-cli:v7.13.0. It covers models, APIs, docs, tests and api/openapi.yaml.

API changes

  • Added: alert configuration, private agents, problems and problem action items, status page teams, phone number verify and resend verification.
  • BREAKING: the alert re-trigger rule endpoints and their models are removed. They're no longer in the published spec.

Post-processing note: the Makefile's post-generation edits use BSD sed -i ''. On GNU/Linux that silently no-ops, because it's masked by || true. The same edits were applied here with GNU sed -i: the Instant parsing in JSON.java, and removing the Object.validateJsonElement / UUID.validateJsonElement calls. The Makefile itself is unchanged. spotlessApply was intentionally not run: enforceCheck false is set, and master's generated code was never formatted.

Release flow, aligned with rootly-ts / rootly-swift

  • publish.yml never created a GitHub release, though CLAUDE.md and PUBLISHING.md said it did. A new release job runs after the Maven Central and GitHub Packages publish. It checks out the repo and fetches the annotated tag. It then promotes the most recent Release Drafter draft, whatever tag the draft resolved to, and renames it to the pushed tag. The annotated tag message is prepended under ## Highlights. Without a draft, it falls back to gh release create --verify-tag --generate-notes. This is the logic rootly-swift used for v2.0.0. rootly-ts got the same fix in rootly-ts#43 after its v0.4.0 release job failed on a tag-name mismatch.
  • release-drafter.yml uses v$RESOLVED_VERSION with the ts version resolvers (breaking → major, enhancement → minor).
  • CHANGELOG.md now points to GitHub Releases. Earlier entries are kept under "Older releases".
  • CLAUDE.md and PUBLISHING.md are updated to match.

Validation: ./gradlew test --no-daemon passes (10,228 tests, 0 failures, 611 skipped). mvn -B package passes. actionlint reports no new findings; the only one is the existing unknown blacksmith-* runner label.

Risk: low. This is a generated SDK refresh plus release-workflow changes. Consumers of the removed endpoints break when they upgrade, so the release should be a major bump.

Link to Devin session: https://rootly.devinenterprise.com/sessions/af696ad13f4e47a09908c76ef0b67191
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/af696ad13f4e47a09908c76ef0b67191?variant=devin
Requested by: @kwent

devin-ai-integration Bot and others added 2 commits October 7, 2026 07:37
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
@kwent
kwent requested a review from a team October 7, 2026 07:52
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

…lights

Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
@kwent
kwent merged commit bad587b into master Oct 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants