Skip to content

ci(integration): ignore leftover records when checking owner_team drift - #27

Merged
devin-ai-integration[bot] merged 1 commit into
masterfrom
devin/1791519946-owner-team-integration-drift
Oct 9, 2026
Merged

devin-ai-integration[bot] merged 1 commit into
masterfrom
devin/1791519946-owner-team-integration-drift

Conversation

@kwent

@kwent kwent commented Oct 9, 2026

Copy link
Copy Markdown
Member

Summary

On its first master run (run 37883666325), the Integration — native owner_team step failed with exit 3 from status --fail-on-drift. The ownership itself was fine: right after the first sync, ci-owned-svc-*, ci-owned-func-* and both owner teams were all noop.

The drift came only from deletes. status computes its plan with prune on. The shared integration account still has teams, services and functionalities left over from other steps and earlier runs (ci-native-team-*, ci-native-func-*, ...), so they show up as pending deletes. The older steps also see Drift detected. but pass anyway, because they use status --fail-on-drift && echo ..., which hides the exit code. #25 made the owner step fail properly on drift, which exposed this.

The owner step now uses assert_owned_in_sync, which reads status --output=json and:

  • fails on any create/update change;
  • requires the 4 records the step owns (2 group:default/ci-owner-* teams, ci-owned-svc-*, ci-owned-func-*) to be noop;
  • ignores deletes of records the step doesn't own.

I checked the parser locally against sample JSON in both cases: a noop/delete mix passes and an update fails. The step only runs on push to master, so it gets its real check when this merges.

Link to Devin session: https://rootly.devinenterprise.com/sessions/ba7eaa797c98438bb7166d6f8a275fbd
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/ba7eaa797c98438bb7166d6f8a275fbd?variant=devin
Requested by: @kwent

Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@devin-ai-integration
devin-ai-integration Bot merged commit 62fc7af into master Oct 9, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant