Repository navigation
ci(integration): ignore leftover records when checking owner_team drift - #27
Merged
devin-ai-integration[bot] merged 1 commit intoOct 9, 2026
Conversation
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On its first master run (run 37883666325), the
Integration — native owner_teamstep failed with exit 3 fromstatus --fail-on-drift. The ownership itself was fine: right after the first sync,ci-owned-svc-*,ci-owned-func-*and both owner teams were allnoop.The drift came only from deletes.
statuscomputes its plan with prune on. The shared integration account still has teams, services and functionalities left over from other steps and earlier runs (ci-native-team-*,ci-native-func-*, ...), so they show up as pending deletes. The older steps also seeDrift detected.but pass anyway, because they usestatus --fail-on-drift && echo ..., which hides the exit code. #25 made the owner step fail properly on drift, which exposed this.The owner step now uses
assert_owned_in_sync, which readsstatus --output=jsonand:create/updatechange;group:default/ci-owner-*teams,ci-owned-svc-*,ci-owned-func-*) to benoop;deletes of records the step doesn't own.I checked the parser locally against sample JSON in both cases: a
noop/deletemix passes and anupdatefails. The step only runs on push to master, so it gets its real check when this merges.Link to Devin session: https://rootly.devinenterprise.com/sessions/ba7eaa797c98438bb7166d6f8a275fbd
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/ba7eaa797c98438bb7166d6f8a275fbd?variant=devin
Requested by: @kwent