[async worker] align engine tests with runtime behavior - #460
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe test suite now verifies ChangesGC source update test coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates async engine tests to match existing runtime behavior without changing production code; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description
Align the async engine recompile tests with the runtime behavior introduced by #454. The GC test now verifies the required collect-then-freeze sequence, and the cycle-break fixture now models the iterable, hashable
Sourcescontract instead of using a plain list.Related Issues/Tasks
Models used
Testing
gc.collect()expectation and missingSources.hash()errorsuv run pytest osprey_async_worker/src/osprey/async_worker/tests/test_engine.py -q(7 passed)uv run pytest osprey_async_worker/src/osprey/async_worker/tests -q(124 passed)uv run ruff check .uv run ruff format --diff osprey_async_worker/src/osprey/async_worker/tests/test_engine.pyuv run mypy osprey_async_worker/src/osprey/async_worker/tests/test_engine.pyuv tool run fawltydeps --check-unused --pyenv .venvChecklist
uv run ruff check .passes (no unused imports or other lint errors)uv tool run fawltydeps --check-unused --pyenv .venvpasses (no unused dependencies)CHANGELOG.mdwith my changes, if notable (not applicable; test-only correction)Summary by CodeRabbit