feat(ask): host-neutral Ask turn service - #426
Draft
haileyok wants to merge 1 commit into
Draft
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Add osprey_worker/lib/ask: vendor-neutral contracts (AskRequest/AskEvent/Principal/ AskLimits/Conversation/ContextSnapshot/ResolvedModel), a stable error taxonomy, host adapter Protocols (ModelPolicy, ConversationStore, ConversationLock, ContextSnapshotProvider, ToolRegistryFactory, Redactor, AuditSink, EvidenceNormalizer) + AskConfig, and AskService.run_turn -- a generator that pre-flights (raising before any event), streams a deterministic bounded tool loop, redacts structured payloads, enforces history/context/output budgets, checks cancellation, persists only successful turns, and releases the conversation lock on every terminal path. Tests (28 passing under run-tests.sh) cover the deterministic event sequence, tool feed-back, multi-tool ordering, iteration/output budgets, ownership + pre-flight rejections, provider/tool/cancellation/lock failures, structured redaction, and audit-failure isolation. Implements osprey-ask-ai AC2.1-AC2.5, AC3.1-AC3.5.
haileyok
force-pushed
the
hailey/ask-ai-2-service
branch
from
July 14, 2026 22:13
45f307d to
44cfeca
Compare
haileyok
force-pushed
the
hailey/ask-ai-1-provider
branch
from
July 14, 2026 22:13
3917584 to
f2f422c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 2/5 of the Ask AI stack (stacked on
hailey/ask-ai-1-provider). Addsosprey_worker/lib/ask: vendor-neutral contracts, a stable error taxonomy, host adapter Protocols (ModelPolicy, ConversationStore, ConversationLock, ContextSnapshotProvider, ToolRegistryFactory, Redactor, AuditSink, EvidenceNormalizer) +AskConfig, andAskService.run_turn— a generator that pre-flights before emitting, streams a deterministic bounded tool loop, redacts structured payloads, enforces history/context/output budgets, checks cancellation, persists only successful turns, and releases the lock on every terminal path. Implements AC2.1–AC2.5, AC3.1–AC3.5.Checklist
./run-tests.sh)uv run ruff check .passesuv tool run fawltydeps --check-unused --pyenv .venvpassesCHANGELOG.md(deferred — happy to add)