Update faq.md - #2
Open
ronny-mysten wants to merge 1 commit into
Open
Conversation
Updated links to channels.
ronny-mysten
pushed a commit
that referenced
this pull request
Jul 28, 2023
…primitives (MystenLabs#13160) ## Description This PR adds the new "Protect Account" screen used when clicking "Create a new account" button and as the second step of the "Import Passphrase" and "Import Private Key" flows. As part of this, I attempted to create some new form primitives to make building forms more manageable (all of the existing components aren't quite up to spec, use Formik, and aren't fully accessible). I ended up following an approach similar to https://www.brendonovich.dev/blog/the-ultimate-form-abstraction which gave some creds to @Jordan-Mysten 😆 As a rough outline, we have generic, non-form-library-specific input controls like `TextArea`, `Input`, `PasswordInput`, `Checkbox` which are used to create `react-hook-form` specific controls such as `TextField`, `TextAreaField`, `CheckboxField`, and so forth. We also have some helper components like `Form` and `FormField` to help abstract away some specific form details such as error states when using react-hook-form. I considered using the Radix form primitives, but I didn't really see the immediate value 🤷🏼 Additional note #1: Some of these pages are used in different flows and have different submission logic depending on the usage context. I think I might need to brainstorm on the best way to handle that and tackle it in a follow-up PR Additional note #2: the auto-lock input is still a WIP on the design side, so I have a TODO to add that once it's ready. Checkbox in Figma - https://www.figma.com/file/T06obgYVOUD2JDGXM8QEDX?node-id=341%3A378&main-component=1&fuid=1209977329759347633 Input in Figma - https://www.figma.com/file/T06obgYVOUD2JDGXM8QEDX/01-Components-%3A-Shared?node-id=19%3A312&mode=dev <img width="631" alt="image" src="https://github.com/MystenLabs/sui/assets/7453188/4c851808-b751-412a-b25e-06d4660b5fa3"> ## Test Plan - Manual testing (error states, successful submission, accessibility, focus/disabled/hover states, etc.) - CI --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [ ] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
ronny-mysten
pushed a commit
that referenced
this pull request
Aug 1, 2025
## Description
Add a benchmark for process_commit() with direct and indirect logic.
This requires turning some types and functions pub and non-test, which
is unfortunate. The alternative is to not use `cargo bench` which seems
worse.
Avoid excessive copying of rejected transaction votes. There are some
remaining copying, but removing them shows minimal impact in benchmarks.
Process chunks of blocks in parallel.
### Benchmark results
With 100 authorities, 20 transactions per block, voting to reject 50% of
transactions randomly:
Original:
```
CommitFinalizer/process_commit_indirect
time: [7.3273 ms 7.3906 ms 7.4555 ms]
thrpt: [13.413 Kelem/s 13.531 Kelem/s 13.648 Kelem/s]
change:
time: [-2.1521% -0.9914% +0.1867%] (p = 0.10 > 0.05)
thrpt: [-0.1863% +1.0013% +2.1995%]
No change in performance detected.
Found 2 outliers among 100 measurements (2.00%)
2 (2.00%) high mild
Direct commits: 102700; Indirect commits: 0; Rejected transactions: 0
Benchmarking CommitFinalizer/process_commit_indirect #2: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 90.0s. You may wish to increase target time to 682.8s, or reduce sample count to 10.
CommitFinalizer/process_commit_indirect #2
time: [5.7617 s 5.7709 s 5.7810 s]
thrpt: [17.298 elem/s 17.328 elem/s 17.356 elem/s]
change:
time: [+519.22% +522.23% +524.70%] (p = 0.00 < 0.05)
thrpt: [-83.992% -83.929% -83.851%]
Performance has regressed.
Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe
Direct commits: 0; Indirect commits: 9797; Rejected transactions: 8469
```
New:
```
CommitFinalizer/process_commit_indirect
time: [13.382 ms 13.553 ms 13.730 ms]
thrpt: [7.2834 Kelem/s 7.3784 Kelem/s 7.4725 Kelem/s]
change:
time: [+0.9942% +2.8433% +4.6313%] (p = 0.00 < 0.05)
thrpt: [-4.4263% -2.7647% -0.9844%]
Change within noise threshold.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
6 (6.00%) high mild
Direct commits: 23100; Indirect commits: 0; Rejected transactions: 0
Benchmarking CommitFinalizer/process_commit_indirect #2: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 90.0s. You may wish to increase target time to 201.0s, or reduce sample count to 40.
CommitFinalizer/process_commit_indirect #2
time: [931.45 ms 933.58 ms 935.98 ms]
thrpt: [106.84 elem/s 107.11 elem/s 107.36 elem/s]
change:
time: [-0.4712% -0.0741% +0.3809%] (p = 0.72 > 0.05)
thrpt: [-0.3795% +0.0741% +0.4734%]
No change in performance detected.
Found 11 outliers among 100 measurements (11.00%)
8 (8.00%) high mild
3 (3.00%) high severe
Direct commits: 0; Indirect commits: 9991; Rejected transactions: 8476
```
This shows > 6x throughput increase from 17 commits/s to 107 commits/s.
## Test plan
`cargo bench -p consensus-core --bench commit_finalizer_bench`
---
## Release notes
Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.
For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.
- [ ] Protocol:
- [ ] Nodes (Validators and Full nodes):
- [ ] gRPC:
- [ ] JSON-RPC:
- [ ] GraphQL:
- [ ] CLI:
- [ ] Rust SDK:
ronny-mysten
added a commit
that referenced
this pull request
Aug 27, 2025
…#23273) ## Description Implementation of style guide rules for active voice, etc ## Test plan N/A --- ## Release notes Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required. For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates. - [ ] Protocol: - [ ] Nodes (Validators and Full nodes): - [ ] gRPC: - [ ] JSON-RPC: - [ ] GraphQL: - [ ] CLI: - [ ] Rust SDK: --------- Co-authored-by: ronny-mysten <118224482+ronny-mysten@users.noreply.github.com>
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated links to channels.
Description
Describe the changes or additions included in this PR.
Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes