Handling of preprocessor-defined strings in TRICE macro #293

Activity

1. rokath commented on May 27, 2022

   

   rokath

   on May 27, 2022

   Owner

   More actions

   I would expect not working at all or The version is:VERSION_STRING in the given example. You can also have a look into the til.json. My recommendation:

   #define MAJOR 1
   #define MINOR 0
   #define PATCH 0
   TRICE8( "The version is: %d.%d.%d\n");
2. escherstair commented on May 27, 2022

   

   escherstair

   on May 27, 2022

   ContributorAuthor

   More actions

   In this case the workaround is ok, but imagine it's

   #define DUMMY_STRING "this is a dummy string"

   The C preprocessor can concatenate the strings in this way

   printf("The string is:"DUMMY_STRING);

   but I understand that trice tool (at the moment) doesn't play the role of the preprocessor.
   And so

   TRICE("The string is:"DUMMY_STRING);

   doesn't concatenate the string.
3. rokath commented on May 27, 2022

   

   rokath

   on May 27, 2022

   Owner

   More actions

   The **trice ** tool cannot perform, what a preprocessor does. It is limited to simple string replacements. If you really need such string concatenation, you could try a 2nd trice update run on the preprocessor output. But I think it is not worth the effort and brings in difficulties with the ID handling. What about this:

   #define DUMMY_STRING "The string is dummy string"
   TRICE( DUMMY_STRING );

   Then, before running trice u, use a text processor to replace DUMMY_STRING.

   I cannot imagine the need for that. Would you please tell me more about the use case?
4. escherstair commented on May 30, 2022

   

   escherstair

   on May 30, 2022

   Last edited by escherstair

   ContributorAuthor

   More actions

   @rokath I agree with you.
   trice tool cannot do the job of a C preprocessor, and the proposed workaround it's not worth the effort.

   This topic comes from a real job of replacing printf code into trice code.
   Sometimes in C it's quite common using some #define to create compile-time-known items (strings, numbers, ...)
   Usually they're kept into a .h file that can be changed to reconfigure the project with other parameters.
   All this data is know at compile time (after preprocessing task, in reality) and so they could be optimized with trice.
   But the effort is too high and it goes beyond the scope of trice tool.
   I think that the best solution is to use them like dynamic strings or data (subotimal way, but we can live with it):

   #define DUMMY_STRING "The string is dummy string"
   #define MAGIC_NUMBER 3
   ...
   TRICE_S( "msg:%s\n", DUMMY_STRING);
   TRICE( "msg:The value of the magic number is %d\n", MAGIC_NUMBER);
5. rokath commented on Jun 1, 2022

   

   rokath

   on Jun 1, 2022

   Owner

   More actions

   Maybe you can write inside your header file

   #include "trice.h"
   #define DUMMY_STRING TRICE( "msg:The string is dummy string\n");

   and in your C-file

   void fn(void){
       DUMMY_STRING 
   }
   

   This could work but may cause difficulties with the location information what probably is solvable.
6. Repository owner locked and limited conversation to collaborators on Aug 27, 2022
7. rokath

   converted this issue into a discussion #318 on Aug 27, 2022