-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
fix: add Apple Silicon (MPS) device support across lessons #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Jayantkhandebharad
wants to merge
13
commits into
rohitg00:main
Choose a base branch
from
Jayantkhandebharad:fix/mps-device-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a2b27b2
fix(phase-00/01): detect MPS GPU in environment check
jkhandebharad 8b9491a
fix(phase-00/03): add Apple Silicon MPS path to gpu_check
jkhandebharad 2422b2d
fix(phase-00/12): make memory/device debug MPS-aware
jkhandebharad 469128c
fix(phase-03/11): select MPS device when CUDA absent
jkhandebharad ad9c741
fix(phase-04/04): use MPS device when available
jkhandebharad 3de6428
fix(phase-04/05): use MPS device when available
jkhandebharad 9efde4d
fix(phase-04/07): use MPS device when available
jkhandebharad 7da72c4
fix(phase-04/09): use MPS device when available
jkhandebharad 6313b9f
fix(phase-04/10): use MPS device when available
jkhandebharad 7c04451
fix(phase-04/11): run Stable Diffusion on MPS
jkhandebharad 3f8fad7
fix(phase-04/15): sync MPS in latency measurement
jkhandebharad 0446851
fix(phase-04/16): sync MPS in pipeline benchmark
jkhandebharad 1b7402b
fix(phase-19/45): accept mps device_type in AMP state
jkhandebharad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove no-op f-strings to satisfy Ruff F541.
These four strings have no interpolation and trigger lint errors.
Suggested patch
Also applies to: 243-243, 252-252, 257-257
🧰 Tools
🪛 Ruff (0.15.15)
[error] 238-238: f-string without any placeholders
Remove extraneous
fprefix(F541)
🤖 Prompt for AI Agents
Source: Linters/SAST tools