Skip to content

Update landing pages + fix API error in amendment tracker component #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maria-robobug merged 3 commits into from
Aug 12, 2026
Merged

Update landing pages + fix API error in amendment tracker component #226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64d4638
Update landing pages and remove docs
maria-robobug Aug 10, 2026
0efa5c8
Fix AmendmentTracker component API error
maria-robobug Aug 10, 2026
a925237
Address review feedback
maria-robobug Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 37 additions & 12 deletions components/AmendmentTracker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,19 +330,39 @@ export const AmendmentTracker: React.FC<AmendmentTrackerProps> = ({
throw new Error('Could not extract version number');
}

// Create the release branch name
const releaseBranch = `release-${majorMinorVersion}`;

const buildInfoCommitsResponse = await fetch(
`${GITHUB_API_BASE_URI}/commits?path=src/libxrpl/protocol/BuildInfo.cpp&sha=${releaseBranch}&per_page=100`
);
// rippled's release branches moved from "release-X.Y" (e.g. release-3.1)
// to "release/X.Y.x" (e.g. release/3.3.x), so try the current scheme
// first, then the legacy one, then the version tag.
const candidateRefs = [
`release/${majorMinorVersion}.x`,
`release-${majorMinorVersion}`,
baseVersion,
];

// Match "Set version to X.Y.Z" or "Bump version to X.Y.Z" for the exact
// release only; the lookahead excludes -rc and -b pre-releases.
const escapedVersion = baseVersion.replace(/\./g, '\\.');
const versionPattern = new RegExp(`(?:Set|Bump) version to ${escapedVersion}(?![\\d.-])`, 'i');

let buildInfoFetched = false;
for (const ref of candidateRefs) {
const buildInfoCommitsResponse = await fetch(
`${GITHUB_API_BASE_URI}/commits?path=src/libxrpl/protocol/BuildInfo.cpp&sha=${ref}&per_page=100`
);

if (!buildInfoCommitsResponse.ok) {
// Only keep trying other refs when the branch genuinely doesn't
// exist (404). On rate limiting (403) or other errors, stop so we
// don't spend extra requests, matching the original single call.
if (buildInfoCommitsResponse.status !== 404) {
break;
}
continue;
}
buildInfoFetched = true;

if (buildInfoCommitsResponse.ok) {
const buildInfoCommits = await buildInfoCommitsResponse.json();

// Create pattern to match "Set version to X.Y.Z" (exact version, no rc/b builds)
const versionPattern = new RegExp(`Set version to ${baseVersion.replace(/\./g, '\\.')}`, 'i');


// Search through BuildInfo.cpp commit messages
for (const commitData of buildInfoCommits) {
if (versionPattern.test(commitData.commit.message)) {
Expand All @@ -358,7 +378,12 @@ export const AmendmentTracker: React.FC<AmendmentTrackerProps> = ({
break;
}
}
} else {
if (versionCommit) {
break;
}
}

if (!buildInfoFetched) {
throw new Error();
}
} catch (error) {
Expand Down
18 changes: 9 additions & 9 deletions docs/_snippets/common-links.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
[amendment]: https://xrpl.org/docs/concepts/networks-and-servers/amendments
[common fields]: https://xrpl.org/docs/references/protocol/transactions/common-fields/
[common ledger entry fields]: https://xrpl.org/docs/references/protocol/ledger-data/common-fields/
[ConfidentialMPTClawback transaction]: /docs/xls-96-confidential-transfers/references/transactions/confidentialmptclawback.md
[ConfidentialMPTConvert transaction]: /docs/xls-96-confidential-transfers/references/transactions/confidentialmptconvert.md
[ConfidentialMPTConvertBack transaction]: /docs/xls-96-confidential-transfers/references/transactions/confidentialmptconvertback.md
[ConfidentialMPTMergeInbox transaction]: /docs/xls-96-confidential-transfers/references/transactions/confidentialmptmergeinbox.md
[ConfidentialMPTSend transaction]: /docs/xls-96-confidential-transfers/references/transactions/confidentialmptsend.md
[ConfidentialMPTClawback transaction]: https://xrpl.org/docs/references/protocol/transactions/types/confidentialmptclawback
[ConfidentialMPTConvert transaction]: https://xrpl.org/docs/references/protocol/transactions/types/confidentialmptconvert
[ConfidentialMPTConvertBack transaction]: https://xrpl.org/docs/references/protocol/transactions/types/confidentialmptconvertback
[ConfidentialMPTMergeInbox transaction]: https://xrpl.org/docs/references/protocol/transactions/types/confidentialmptmergeinbox
[ConfidentialMPTSend transaction]: https://xrpl.org/docs/references/protocol/transactions/types/confidentialmptsend
[ConfidentialTransfers amendment]: https://xls.xrpl.org/xls/XLS-0096-confidential-mpt.html
[credentials]: https://xrpl.org/docs/concepts/decentralized-storage/credentials
[DynamicMPT amendment]: https://xls.xrpl.org/xls/XLS-0094-dynamic-MPT.html
Expand All @@ -31,10 +31,10 @@
[SHA-512Half]: https://xrpl.org/docs/references/protocol/data-types/basic-data-types#hashes
[Specifying Ledgers]: https://xrpl.org/docs/references/protocol/data-types/basic-data-types/#specifying-ledgers
[Sponsor amendment]: https://xls.xrpl.org/xls/XLS-0068-sponsored-fees-and-reserves.html
[Sponsorship ledger entry]: /docs/xls-68-sponsored-fees-and-reserves/references/ledger-entries/sponsorship.md
[SponsorshipSet transaction]: /docs/xls-68-sponsored-fees-and-reserves/references/transactions/sponsorshipset.md
[SponsorshipTransfer]: /docs/xls-68-sponsored-fees-and-reserves/references/transactions/sponsorshiptransfer.md
[SponsorshipTransfer transaction]: /docs/xls-68-sponsored-fees-and-reserves/references/transactions/sponsorshiptransfer.md
[Sponsorship ledger entry]: https://xrpl.org/docs/references/protocol/ledger-data/ledger-entry-types/sponsorship
[SponsorshipSet transaction]: https://xrpl.org/docs/references/protocol/transactions/types/sponsorshipset
[SponsorshipTransfer]: https://xrpl.org/docs/references/protocol/transactions/types/sponsorshiptransfer
[SponsorshipTransfer transaction]: https://xrpl.org/docs/references/protocol/transactions/types/sponsorshiptransfer
[standard format]: https://xrpl.org/docs/references/http-websocket-apis/api-conventions/response-formatting/
[transaction result codes]: https://xrpl.org/docs/references/protocol/transactions/transaction-results
[universal error types]: https://xrpl.org/docs/references/http-websocket-apis/api-conventions/error-formatting#universal-errors
Expand Down
30 changes: 24 additions & 6 deletions docs/xls-56-batch-transactions/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,9 @@ export default function Page() {
keyDates={keyDates}
/>

<AmendmentTracker
amendmentId="894646DD5284E97DECFE6674A6D6152686791C4A95F8C132CCA9BAF9E5812FB6"
<AmendmentTracker
amendmentId="9F287AED3CDB50A7BD1ACEC24296A30C9B5230CCD136219317AC790E3B884377"
xlsSpecDate="2025-01-23"
devnetDate="2025-05-24"
mainnetDate="2025-06-24"
onKeyDatesUpdate={handleKeyDatesUpdate}
/>

Expand All @@ -77,6 +75,17 @@ export default function Page() {
</p>
<ButtonToXRPL>Read the Concepts</ButtonToXRPL>
</Card>
<Card
title="Blog"
to="https://dev.to/ripplexdev/introducing-batch-transactions-on-the-xrp-ledger-more-opportunities-less-friction-50h5"
>
<p>
An overview of the feature and why it matters to developers, explained in our blog post.
</p>
<Button size="large" variant="primary">
Read the Blog
</Button>
</Card>
<Card
title="Tutorials"
to="https://xrpl.org/docs/tutorials/best-practices/transaction-sending/send-a-single-account-batch-transaction"
Expand All @@ -96,12 +105,21 @@ export default function Page() {
</Card>
<Card title="Performance Testing" to="https://dev.to/ripplexdev/batch-transaction-performance-testing-report-13j8">
<p>
The performance testing report to assess the performance implications of the feature.
The performance testing report to assess the performance implications of the feature.
</p>
<Button size="large" variant="primary">
Read the Perf Testing Report
</Button>
</Card> </Cards>
</Card>
<Card title="QA Test Report" to="https://dev.to/ripplexdev/batch-transaction-qa-test-report-17em">
<p>
The QA Test Report presents results of QA testing performed on the feature across rippled and Clio servers.
</p>
<Button size="large" variant="primary">
Read the QA Testing Report
</Button>
</Card>
</Cards>
</LandingContainer>
</LandingLayout>
);
Expand Down
124 changes: 0 additions & 124 deletions docs/xls-68-sponsored-fees-and-reserves/concepts/sponsored-fees-and-reserves.md
View file
Open in desktop

This file was deleted.

16 changes: 8 additions & 8 deletions docs/xls-68-sponsored-fees-and-reserves/index.page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@ import {
LandingContainer,
LandingLayout,
FeatureHeader,
FeatureContent
FeatureContent,
ButtonToXRPL
} from "../../components/landing";
import { AmendmentTracker } from "../../components/AmendmentTracker";
import { Button } from "@redocly/theme";
Expand Down Expand Up @@ -67,16 +68,15 @@ export default function Page() {
</Card>

<Card
title="Documentation"
to="docs/xls-68-sponsored-fees-and-reserves/concepts/sponsored-fees-and-reserves"
title="Concepts"
to="https://xrpl.org/docs/concepts/accounts/sponsored-fees-and-reserves"
>
<p>
Explore key concepts, find detailed references, and follow
step-by-step tutorials.
Documentation on the feature, including how it works and why.
</p>
<Button size="large" variant="primary">
Read the Docs
</Button>
<ButtonToXRPL>
Read the Concepts
</ButtonToXRPL>
</Card>

<Card
Expand Down
Loading