simpleXRPL docs - #224
Conversation
|
|
||
| // Palisade — authenticates via OAuth client credentials and acts on a | ||
| // specific vault/wallet. | ||
| const palisade = await PalisadeCustody.create({ |
There was a problem hiding this comment.
just confirming that it's correct that we have no url for ripple custody but we do for palisade? @pdp2121
There was a problem hiding this comment.
Yes that's correct afaik. Cant tag Cybele here to confirm
There was a problem hiding this comment.
Just added her to review team, tagging @cybele-ripple
maria-robobug
left a comment
There was a problem hiding this comment.
Added mostly some style and formatting comments.
One thing to note, I think the use of "Token" for MPTs is confusing, but I get that this is how it's been implemented. It would be good if we could keep some of the terminology consistent with xrpl.org to avoid confusion.
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
Co-authored-by: Maria Shodunke <maria-robobug@users.noreply.github.com>
| ## Example | ||
|
|
||
| ```ts | ||
| const { address, seed } = client.account.create() |
There was a problem hiding this comment.
Update code sample to not be reached off client.
|
|
||
| [[Source]](https://github.com/ripple/simpleXRPL/blob/50619258cf753008e8a185eaeb3ceca489e5998a/src/verticals/account.ts#L72) | ||
|
|
||
| Generate a new XRPL keypair locally and register it so it can be funded and used right away. Use this only to mint an additional account outside of `SimpleXRPL.init`. |
There was a problem hiding this comment.
Add note: only meant for local connectors.
This PR adds these
simpleXRPLSDK docs: