Add limited support for mkv - #71
Open
mikeage wants to merge 1 commit into
Open
Conversation
In brief testing, Chrome and Firefox seem happy, but Safari does not play these videos.
Author
|
This doesn't address any of the discussion in #65 around transcoding, it simply sidesteps it and relies on the user to accept that Chrome/FF/Edge is better than Safari. |
Author
|
(I'm not sure if this repo is still active, but hopefully...) |
Owner
|
Hi, happy to see your contribution, thank you! I will make some testing around this and merge it once I'm happy with it. |
Author
|
Thank you! Note that it fails silently in Safari :-/ I'm running it from a fork for my local use case, but if you want something better for the official release, I wouldn't be offended. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In brief testing, Chrome and Firefox seem happy, but Safari does not play these videos.