VM: Implement indexer fallback for missing properties. - #1147
Open
schungx wants to merge 5 commits into
Open
Conversation
ImTheSquid
requested changes
Aug 21, 2026
ImTheSquid
left a comment
Collaborator
There was a problem hiding this comment.
Unused variable warnings should be handled through this kinda deal:
fn foo(
#[cfg_attr(feature="no_*", allow(unused))] var: Typ
) {}Other than that LGTM
Collaborator
Author
Are there unused? Let me double check... I thought I caught them all... EDIT: Ah, gotcha. |
Collaborator
Author
It was too many attributes to put on the parameters, I ended up using this: let _ = (target, key, value, fail_silently, pos);This will get removed by the compiler during optimization so it won't affect performance. I see a couple of places in |
ImTheSquid
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, the VM does not fallback to trying an indexer (getter or setter) when access to a property failed.
This PR implements this behavior so it'll match the AST walker.