EXPERIMENTAL: compiled vm callback - #1144
Draft
schungx wants to merge 5 commits into
Draft
Conversation
schungx
force-pushed
the
experimental-compiled-vm-callback
branch
from
August 20, 2026 10:18
dd10480 to
5e606ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ImTheSquid I have pushed an experimental branch called
experimental-compiled-vm-callbackwhich illustrates my idea. Can you take a look? For reference only at this point.What it does:
Eliminated a lot of the stuff such as
makes_pointer,needs_this, etc.Eliminated the need to keep a lib of the AST for walking. This has the side effect that some features such as
import,evaletc. won't compile.Seems to work with anything I've thrown at it so far...
Eliminated the need to consider arity in callbacks... everything just works, because the arity is not in question -- the function is scripted, and it always has
this(even if unused), so the shape is fixed.Surgical changes in
fn_ptr.rs... It is now simplyFnPtrType::Compiledwith no attached info. Just a marker.There is no observed regression in performance.
The essence is these two changes. They make sure compiled chunks are always called with a
thispointer at the front (it may be a dummy if not used). This takes care of all our arity problems.