fix for upload binary data via cpp bindings - #696
Open
sasokol wants to merge 1 commit into
Open
Conversation
Member
|
Looks good to me, but it requires a test, please add one which calls some method with binary data and results you read back is invalid for current code and works good with your new code. |
Author
|
Example: |
|
|
||
| argument_data_base(const char *data) : | ||
| m_data(pointer_type::from_raw(const_cast<char *>(data), std::strlen(data))) | ||
| m_data(pointer_type::from_raw(const_cast<char *>(data), std::strlen(data))) // It isn't correct for binary data. |
There was a problem hiding this comment.
// It isn't correct for binary data.
This comment is unnecessary as the constructor is not about binary data.
|
The pull request is not "fix" actually, as there's no bug. You just added "helper" constructor for binary data. Without the "fix" you can already use the constructor from |
Author
|
OK, thank you. It works... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a new constructor with data size.