merge recovery: optimization: use copy-iterator & server-send for small/medium keys - #678
Conversation
There was a problem hiding this comment.
What are the destination groups?
There was a problem hiding this comment.
CopyIterator is used in merge recovery only, that's why exactly one group specified here.
There was a problem hiding this comment.
CopyIterator name implies the opposite, please add documentation describing how it is used and better change the name
There was a problem hiding this comment.
Please add description of how does this class work, what is the logic behind it and so on, as much information as possible
There was a problem hiding this comment.
This class doesn't update any statistics, so it is impossible to track recovery progress.
99366eb to
21e1e70
Compare
merge recovery: optimization: use copy-iterator & server-send for small/medium keys
There was a problem hiding this comment.
It should also update statistics in own way, because now it will not show any recovering progress and all iterator's statistics will be about keys which weren't recovered by copy-iterator.
There was a problem hiding this comment.
for key_id, key_responses in responses.iteritems() to get rid of val[1] and val[0]
There was a problem hiding this comment.
Please, take a look at #679 where this PR was complemented.
4 participants
No description provided.