docs(ci): say why reqstool is installed unpinned here - #35
Merged
Conversation
Every other tool install in the org is pinned. This one is not, and the reason should be in the file rather than inferred: this repo exists to check the fixtures against whatever reqstool currently releases. Pinning would test them against a fixed past version and stop catching the regressions it is named for. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ⓘ Follow-up to the org-wide pinning sweep. This repo is the one deliberate exception, and the reason belongs in the file.
What & Why
Every other tool install across the reqstool repos is now pinned. This one is not — and someone tidying up later would reasonably "fix" it.
This repo exists to check the fixtures against whatever reqstool currently releases. Pinning would test them against a fixed past version and stop catching the regressions it is named for.
No behaviour change; a comment only. (
reqstool/.github’sinstall-reqstoolaction gets the same note for the same reason — its build matrix runsreqstool-source: [pypi, main]precisely to exercise the current release.)Author checklist
actionlintclean