build(pypi): pin pytest-asyncio - #440
Merged
Merged
Conversation
The only dependency in this repo still declared as a range. A range means the version installed depends on when you install, so CI, a laptop and a release build can each resolve differently. Pinned to 0.26.0, the newest release inside the range it already declared, so nothing changes behaviourally. Deliberately not 1.4.0. pytest-asyncio 1.0 was a breaking release, and this suite depends on the behaviour it changed -- `asyncio_mode = "auto"` and `asyncio_default_fixture_loop_scope = "module"` are both set. Pinning removes the `<1.0` cap, so Renovate will now propose 1.x as an ordinary PR and CI will say whether the suite survives it. That is a better way to find out than assuming it here. Signed-off-by: Jimisola Laursen <jimisola@jimisola.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & Why
Every dependency in the reqstool repos is now pinned to an exact version. A range means the version you get depends on when you install — CI, a laptop and a release build can each resolve differently — and a bad upstream release lands without a PR anyone reviewed.
Renovate keeps proposing upgrades exactly as before; they now arrive as reviewable PRs that CI has to pass, rather than silently.
Paired with reqstool/.github#77, which sets
rangeStrategy: "pin"org-wide so nothing drifts back.This repo
pytest-asyncio>=0.25,<1.0→pytest-asyncio==0.26.0— the only dependency here still declared as a range. 0.26.0 is the newest release inside the range it already declared, so nothing changes behaviourally.Deliberately not 1.4.0
pytest-asyncio 1.0 was a breaking release, and this suite depends on what it changed —
asyncio_mode = "auto"andasyncio_default_fixture_loop_scope = "module"are both set inpyproject.toml.Pinning removes the
<1.0cap, so Renovate will now propose 1.x as an ordinary PR and CI will say whether the suite survives it. That is a better way to find out than guessing here.