Skip to content

EPMRPP-115237 || Move encryption logic to service-api - #126

Merged
grabsefx merged 3 commits into
developfrom
EPMRPP-115237-encrypt-sensitive
Jun 17, 2026
Merged

grabsefx merged 3 commits into
developfrom
EPMRPP-115237-encrypt-sensitive

Conversation

@Evelina02

@Evelina02 Evelina02 commented Jun 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Chores

    • Updated service API library dependency to the latest version.
  • Bug Fixes

    • Improved Jira integration parameter handling for API token retrieval during project creation and update operations.

@coderabbitai

coderabbitai Bot commented Jun 16, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@Evelina02, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 25 minutes and 42 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0eae82ae-fb46-4c7e-8b1b-539da5283378

📥 Commits

Reviewing files that changed from the base of the PR and between 298f6bf and 1178ac1.

📒 Files selected for processing (1)
  • build.gradle

Walkthrough

RetrieveCreationParamsCommand and RetrieveUpdateParamsCommand have their BasicTextEncryptor constructor parameter, field, and encrypt() call removed, returning API tokens raw. CloudJiraExtension.getCommonCommands() is updated accordingly. The service-api snapshot dependency version is bumped from e81b4f6 to 60a4c2bb.

Changes

Remove BasicTextEncryptor from retrieve-params commands

Layer / File(s) Summary
Remove encryption from commands and update wiring
src/main/java/com/epam/reportportal/extension/jira/command/RetrieveCreationParamsCommand.java, src/main/java/com/epam/reportportal/extension/jira/command/RetrieveUpdateParamsCommand.java, src/main/java/com/epam/reportportal/extension/jira/CloudJiraExtension.java
Removes BasicTextEncryptor field, constructor injection, and textEncryptor.encrypt(...) call from both retrieve-params commands so API_TOKEN is stored and returned as a raw value. CloudJiraExtension.getCommonCommands() drops the textEncryptor argument from both command constructors.

service-api snapshot version bump

Layer / File(s) Summary
Dependency version update
build.gradle
Updates com.epam.reportportal:service-api snapshot from e81b4f6 to 60a4c2bb for both implementation and annotationProcessor.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 Hop hop, the token flies free,
No encrypt wrapping—plain as can be!
The constructor shed its extra weight,
Raw tokens pass right through the gate.
A version bump joins the parade—
Another sprint in the rabbit's arcade! 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: removing encryption logic from the plugin by updating the service-api dependency and removing textEncryptor usage from command classes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch EPMRPP-115237-encrypt-sensitive

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@grabsefx
grabsefx merged commit 072f311 into develop Jun 17, 2026
3 checks passed
@grabsefx
grabsefx deleted the EPMRPP-115237-encrypt-sensitive branch June 17, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants