feat: add browser-native playground#3123
Conversation
|
LGTM |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds a new cog playground command with an embedded browser-native SPA, reverse proxy, webhook relay, and comprehensive tests. The Go server code is well-structured with proper security headers, CORS bypass via proxying, and loopback-only protection for UI routes. Tests cover proxy behavior, SSE framing, webhook concurrency limits, and asset integrity.
One issue found:
test:playgroundtask doesn't ensure Node.js is installed — Thetest:playgroundmise task runsnode --test '*.test.js'but doesn't declarenodeas a tool dependency. Unlikefmt:playground,lint:playground, andtypecheck:playground, it neither depends onplayground:installnor specifiestools. This breaksmise run testfor developers without Node already in their PATH.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a new One issue found:
I've posted a review with a suggestion on |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds a new cog playground command with an embedded browser-native SPA, reverse proxy, webhook relay, and comprehensive tests. The Go server code is well-structured with proper security headers, CORS bypass via proxying, and loopback-only protection for UI routes. Tests cover proxy behavior, SSE framing, webhook concurrency limits, and asset integrity.
One issue found:
test:playgroundtask doesn't ensure Node.js is installed — Thetest:playgroundmise task runsnode --test '*.test.js'but doesn't declarenodeas a tool dependency. Unlikefmt:playground,lint:playground, andtypecheck:playground, it has nodependsortoolsdeclaration. This breaksmise run testfor developers without Node already in their PATH.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a new One issue found:
Posted a suggestion on |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds a new cog playground command with an embedded browser-native SPA, reverse proxy, webhook relay, and comprehensive tests.
One issue found:
test:playgroundtask doesn't ensure Node.js is installed — Thetest:playgroundmise task runsnode --test '*.test.js'but doesn't declarenodeas a tool dependency. Unlikefmt:playground,lint:playground, andtypecheck:playground, it has nodependsortoolsdeclaration. This breaksmise run testfor developers without Node already in their PATH. The CI job works around this withactions/setup-node, but local development is affected.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a new One issue found:
Posted a suggestion on |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds a new cog playground command with an embedded browser-native SPA, reverse proxy, webhook relay, and comprehensive tests.
One issue found:
test:playgroundtask doesn't ensure Node.js is installed — Thetest:playgroundmise task runsnode --test '*.test.js'but doesn't declarenodeas a tool dependency. Unlikefmt:playground,lint:playground, andtypecheck:playground, it has nodependsortoolsdeclaration. This breaksmise run testfor developers without Node already in their PATH. The CI job works around this withactions/setup-node, but local development is affected.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a new One issue found:
I've posted a review with a suggestion on |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds a new cog playground command with an embedded browser-native SPA, reverse proxy, webhook relay, and comprehensive tests.
One issue found:
test:playgroundtask doesn't ensure Node.js is installed — Thetest:playgroundmise task runsnode --test '*.test.js'but doesn't declarenodeas a tool dependency. Unlikefmt:playground,lint:playground, andtypecheck:playground, it has nodependsortoolsdeclaration. This breaksmise run testfor developers without Node already in their PATH. The CI job works around this withactions/setup-node, but local development is affected.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a new One issue found:
I've posted a review with a suggestion on |
There was a problem hiding this comment.
I'm Bonk, and I've done a quick review of your PR.
This PR adds a new cog playground command with an embedded browser-native SPA, reverse proxy, webhook relay, and comprehensive tests.
One issue found:
test:playgroundtask doesn't ensure Node.js is installed — Thetest:playgroundmise task runsnode --test '*.test.js'but doesn't declarenodeas a tool dependency. Unlikefmt:playground,lint:playground, andtypecheck:playground, it has nodependsortoolsdeclaration. This breaksmise run testfor developers without Node already in their PATH. The CI job works around this withactions/setup-node, but local development is affected.
|
I'm Bonk, and I've done a quick review of your PR. This PR adds a new One issue found:
Posted a suggestion on |
|
@anish-sahoo Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
|
LGTM |
Summary
cog playgroundSPA with no production frontend buildTesting
mise run test:playgroundmise run typecheck:playgroundmise run lint:playgroundmise run fmt:playgroundgo test ./pkg/climise run lint:gomise run fmt:gomise run docs:llm:checkmise run docs:cli:checkmise run fmt:docsmise run lint:docsmise run build:cog