ci(e2e): lighter iOS simulator syslog in Maestro artifacts - #633
Merged
Merged
Conversation
The debug-level simctl log stream produced a ~450MB ios-syslog.log that was uploaded with every iOS Maestro run and not consumed anywhere. Crash reports, Maestro output, screenshots and recordings are still uploaded. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Claude finished @ignaciosantise's task in 1m 1s —— View job Code Review
✅ No issues found The change is clean and correct:
|
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review comments remain.
Review effort: Lite
Findings: None
What changed in this PR
Removes unnecessary iOS simulator syslog capture from Maestro CI artifacts.
Changes:
- Removed
simctl log streamcapture and cleanup. - Removed
ios-syslog.logfrom uploaded artifacts. - Preserved other diagnostic artifacts.
| File | Summary |
|---|---|
.github/actions/walletkit-build-and-maestro/action.yml |
Simplifies iOS Maestro execution and artifact collection. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ignaciosantise
marked this pull request as draft
September 23, 2026 18:54
Stream only the app process at the default log level (no debug/info), with the process name read from the built app's CFBundleExecutable. The previous predicate targeted the pre-Expo RNWallet-Internal process name, so it mostly captured SpringBoard/testmanagerd noise. Upload as a separate artifact only when the tests fail. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
ignaciosantise
changed the title
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The iOS Maestro step uploaded a ~450MB
ios-syslog.logon every run. This PR makes it small and failure-only:--level=debug, so debug/info noise is gone. JSconsole.*output is still included.CFBundleExecutable(currentlyReactNWallet), with a fallback. The old predicate matchedRNWallet-Internal, the name from before the Expo migration (feat(rn_cli_wallet): migrate to Expo (SDK 56) + prebuild/CNG + web for Maestro #555), so recent logs probably held only SpringBoard/testmanagerd/tccd/xctest noise.maestro-ios-syslogartifact. It's no longer part ofmaestro-ios-artifacts.Screenshots/recordings,
ios-crash-reports/**, Maestro debug images andmaestro-output.logare unchanged. Android and web artifacts are unchanged.Test plan
maestro-ios-artifactshas no syslog, and nomaestro-ios-syslogartifact is uploadedmaestro-ios-syslogartifact is uploaded, is small, and contains app log lines🤖 Generated with Claude Code