Fixes, Changes, Add missing - #555
Merged
Merged
Conversation
…low for no spaces after =
Collaborator
|
Looks good to me! Just one formatting error and 2 linter warnings |
Collaborator
|
As a side note: |
duckdoom4
self-requested a review
July 26, 2026 15:05
duckdoom4
approved these changes
Jul 26, 2026
Contributor
Author
|
Thanks for responding, Not sure if my efforts over there will bare any fruit but i guess we'll just have to wait and see, might be interesting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate.pyto now generatetokenizer/generatedevery time rather than only whensyntaxes/json | yamlas thefile changedcheck was unnecessary and only blocked builds (At least from my testing)