Skip to content

fix(docker): exclude .dockerignore from context hash - #126

Open
ethanwu10 wants to merge 1 commit into
masterfrom
fix/ignore-dockerignore
Open

fix(docker): exclude .dockerignore from context hash#126
ethanwu10 wants to merge 1 commit into
masterfrom
fix/ignore-dockerignore

Conversation

@ethanwu10

Copy link
Copy Markdown
Member

Since .dockerignore is a means to control what is in the build context, the contents of the file itself should not be included in the context hash. See #117 for more details.

Closes #117

Since `.dockerignore` is a means to control what is in the build
context, the contents of the file itself should not be included in the
context hash. See #117 for more details.

Closes #117
@ethanwu10 ethanwu10 added component/core kind/bug Something isn't working labels Feb 27, 2021
@codecov

codecov Bot commented Feb 27, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.70%. Comparing base (2107b0a) to head (db0fb48).
⚠️ Report is 33 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   60.70%   60.70%           
=======================================
  Files          27       27           
  Lines         990      990           
  Branches      167      167           
=======================================
  Hits          601      601           
  Misses        375      375           
  Partials       14       14           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core kind/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.dockerignore is included in build context hash

1 participant