Skip to content

refactor(schema-registry): align list with topic/security listings #2546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvorcak wants to merge 4 commits into
base: master
Choose a base branch
from
Open

refactor(schema-registry): align list with topic/security listings #2546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f195c5
refactor(schema-registry): align list with topic/security listings
jvorcak Jul 1, 2026
27f8885
fix(list): render DataTablePagination full-width, align schema info icon
jvorcak Jul 3, 2026
eabefed
chore(dropdown-menu): sync registry, migrate onSelect to onClick
jvorcak Jul 3, 2026
fc5b2da
refactor(schema-registry): move create button to filter row actions
jvorcak Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/src/components/ai-elements/prompt-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,8 +414,8 @@ export const PromptInputActionAddAttachments = ({
return (
<DropdownMenuItem
{...props}
onSelect={(e) => {
e.preventDefault();
closeOnClick={false}
onClick={() => {
attachments.openFileDialog();
}}
>
Expand Down
5 changes: 1 addition & 4 deletions frontend/src/components/pages/quotas/quotas-list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ import {
EmptyHeader,
EmptyTitle,
} from 'components/redpanda-ui/components/empty';
import { ListLayoutPagination } from 'components/redpanda-ui/components/list-layout';
import { Skeleton } from 'components/redpanda-ui/components/skeleton';
import { Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from 'components/redpanda-ui/components/table';
import { Tooltip, TooltipContent, TooltipProvider, TooltipTrigger } from 'components/redpanda-ui/components/tooltip';
Expand Down Expand Up @@ -317,9 +316,7 @@ const QuotasList = () => {
</TableBody>
</Table>

<ListLayoutPagination>
<DataTablePagination table={table} />
</ListLayoutPagination>
<DataTablePagination table={table} />
Comment on lines -320 to +319

@malinskibeniamin malinskibeniamin Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference in how it looks? was it just leftover pattern we did not use?

@jvorcak jvorcak Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed the border around the table, because it's not used like this on other pages.

</PageContent>
</TooltipProvider>
);
Expand Down
Loading
Loading