chore(types): second mypy slice (#158) - #175
Open
jeffmcutter wants to merge 1 commit into
Open
jeffmcutter wants to merge 1 commit into
jeffmcutter wants to merge 1 commit into
Conversation
Add missing annotations and narrow JSON/API ids so the second mypy slice is green without touching CLI. Co-authored-by: Cursor <cursoragent@cursor.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migration/(coordinator,importer,exporter,transformer,state, and related modules).mypy src/aap_migration/migrationis green. Does not add mypy to pre-commit or CI. CLI typing leftovers and Fix CLI/API drift in checkpoint and config show commands #173 (checkpoint /config showAPI drift) remain for later slices.main. After both land, remainingmypy src/failures should be CLI-only.Test plan
mypy src/aap_migration/migrationis clean_as_int/_coerce_source_idguards and theCoordinatorMetricsTypedDict — those are the behavior-adjacent changesMade with Cursor