Preferences API - #54
Draft
JayPanoz wants to merge 7 commits into
Draft
Conversation
With collapsing when needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements a Preference API through
ConfigurableNavigator, in order to provide verbosity – contextualisation and skippability –, and prosody settings.As a result, Navigator now accepts GND content, in order to reextract utterances when preferences are changed, in addition to consumable utterances for simpler cases.
Contextualization being handle through a verbosity layer, fixtures had to be updated to accept an
arrayof roles to announce.This PR does not redesign announcements as contextualisation needs to be discussed.
Demo/update to playground is currently missing, hence the draft status.