Restore eslint path match for assets-registry (fix CI)#57450
Closed
huntie wants to merge 1 commit into
Closed
Conversation
Summary:
D110053924 removed the ESLint config match for `packages/assets-registry/` a little early — the files still exist and an unused suppression warning causes a failure when run with `--max-warnings 0`.
Revert this to restore stable `test_js` jobs on `main`.
{F1992042843}
Changelog: [Internal]
Differential Revision: D110786490
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D110786490. |
|
This pull request has been merged in ef37f40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D110053924 removed the ESLint config match for
packages/assets-registry/a little early — the files still exist and an unused suppression warning causes a failure when run with--max-warnings 0.Revert this to restore stable
test_jsjobs onmain.{F1992042843}
Changelog: [Internal]
Differential Revision: D110786490